-
Couldn't load subscription status.
- Fork 1.8k
Replace GCP/Google Cloud Platform with {gcp-full} #100535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Thu Oct 23 19:25:48 - Prow CI generated the docs preview: |
...iguration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-gcp.adoc
Outdated
Show resolved
Hide resolved
98e69b3 to
94439bf
Compare
06ba345 to
4f7ca9f
Compare
installing/installing_gcp/installing-restricted-networks-gcp-installer-provisioned.adoc
Show resolved
Hide resolved
...iguration/configuring-multi-arch-compute-machines/creating-multi-arch-compute-nodes-gcp.adoc
Outdated
Show resolved
Hide resolved
876e605 to
fd8ed84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left couple of FYI comments.
| // on {gcp-full} | ||
| include::modules/cert-manager-configure-cloud-credentials-gcp-non-sts.adoc[leveloffset=+1] | ||
|
|
||
| // with GCP Workload Identity | ||
| // with {gcp-full} Workload Identity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since attributes are not parsed in comments, this might not be the best fix. Not a blocker. I can handle this one separately. This PR can move on as-is.
| // Configuring an ACME issuer to solve DNS01 challenges by using explicit credentials on GCP | ||
| // Configuring an ACME issuer to solve DNS01 challenges by using explicit credentials on {gcp-full} | ||
| include::modules/cert-manager-acme-dns01-explicit-gcp.adoc[leveloffset=+1] | ||
|
|
||
| // Configuring an ACME issuer to solve DNS01 challenges by using ambient credentials on GCP | ||
| // Configuring an ACME issuer to solve DNS01 challenges by using ambient credentials on {gcp-full} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since attributes are not parsed in comments, this might not be the best fix. Not a blocker. I can handle this one separately. This PR can move on as-is.
|
LGTM for etcd and HCP content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about backing out changes to the API doc file, but otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API docs shouldn't be manually changed.
| ifeval::["{context}" == "installing-gcp-user-infra"] | ||
| :cp-first: Google Cloud Platform | ||
| :cp-first: Google Cloud | ||
| :cp: GCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this {cp} attribute renders to GCP
| * Red{nbsp}Hat must have {gcp-short} console access to the customer-provided {gcp-short} account. This access is protected and managed by Red{nbsp}Hat. | ||
|
|
||
| * The customer must not utilize the GCP account to elevate their permissions within the {product-title} cluster. | ||
| * The customer must not utilize the {gcp-short} account to elevate their permissions within the {product-title} cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'use' rather than 'utilize'. For more information, see RedHat.TermsErrors.
|
|
||
| * If your cluster is configured to use GCP Workload Identity, you followed the instructions from the _Configuring cloud credentials for the cert-manager Operator for Red Hat OpenShift with GCP Workload Identity_ section. | ||
| * If your cluster does not use GCP Workload Identity, you followed the instructions from the _Configuring cloud credentials for the cert-manager Operator for Red Hat OpenShift on GCP_ section. | ||
| * If your cluster is configured to use {gcp-short} Workload Identity, you followed the instructions from the _Configuring cloud credentials for the cert-manager Operator for Red Hat OpenShift with {gcp-short} Workload Identity_ section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.SuggestAttribute: Use the AsciiDoc attribute '{cert-manager-operator}' rather than the plain text product term 'cert-manager Operator for Red Hat OpenShift', unless your use case is an exception.
|
|
||
|
|
||
| The {product-title} cluster uses a number of Google Cloud Platform (GCP) components, but the default link:https://cloud.google.com/docs/quota[quotas] do not affect your ability to install an {product-title} cluster. | ||
| The {product-title} cluster uses a number of {gcp-first} components, but the default link:https://cloud.google.com/docs/quota[quotas] do not affect your ability to install an {product-title} cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'several' rather than 'a number of'. For more information, see RedHat.TermsErrors.
| = {gcp-short} account limits | ||
|
|
||
| The {product-title} cluster uses a number of Google Cloud Platform (GCP) | ||
| The {product-title} cluster uses a number of {gcp-first} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'several' rather than 'a number of'. For more information, see RedHat.TermsErrors.
| ifdef::aws[You can launch a Spot Instance on AWS by adding `spotMarketOptions` to your compute machine set YAML file.] | ||
| ifdef::azure[You can launch a Spot VM on Azure by adding `spotVMOptions` to your compute machine set YAML file.] | ||
| ifdef::gcp[You can launch a preemptible VM instance on GCP by adding `preemptible` to your compute machine set YAML file.] | ||
| ifdef::gcp[You can launch a preemptible VM instance on {gcp-short} by adding `preemptible` to your compute machine set YAML file.] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.
| endif::azure[] | ||
| ifdef::gcp[] | ||
| You can save on costs by creating a compute machine set running on GCP that deploys machines as non-guaranteed preemptible VM instances. Preemptible VM instances utilize excess Compute Engine capacity and are less expensive than normal instances. You can use preemptible VM instances for workloads that can tolerate interruptions, such as batch or stateless, horizontally scalable workloads. | ||
| You can save on costs by creating a compute machine set running on {gcp-short} that deploys machines as non-guaranteed preemptible VM instances. Preemptible VM instances utilize excess Compute Engine capacity and are less expensive than normal instances. You can use preemptible VM instances for workloads that can tolerate interruptions, such as batch or stateless, horizontally scalable workloads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'use' rather than 'utilize'. For more information, see RedHat.TermsErrors.
| ---- | ||
|
|
||
| . View the machines and machine sets that exist in the `openshift-machine-api` namespace by running the following command. Each compute machine set is associated with a different availability zone within the GCP region. The installer automatically load balances compute machines across availability zones. | ||
| . View the machines and machine sets that exist in the `openshift-machine-api` namespace by running the following command. Each compute machine set is associated with a different availability zone within the {gcp-short} region. The installer automatically load balances compute machines across availability zones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'installation program' rather than 'The installer'. For more information, see RedHat.TermsErrors.
| [NOTE] | ||
| ==== | ||
| Red Hat recommends using Workload Identity Federation as the Authentication type. For more information, see xref:../osd_gcp_clusters/creating-a-gcp-cluster-with-workload-identity-federation.adoc#osd-creating-a-cluster-on-gcp-with-workload-identity-federation[Creating a cluster on GCP with Workload Identity Federation authentication]. | ||
| Red Hat recommends using Workload Identity Federation as the Authentication type. For more information, see xref:../osd_gcp_clusters/creating-a-gcp-cluster-with-workload-identity-federation.adoc#osd-creating-a-cluster-on-gcp-with-workload-identity-federation[Creating a cluster on {gcp-short} with Workload Identity Federation authentication]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies.
|
@bscott-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
LGTM |
|
Closed in favor of #101036 |
Versions: 4.12+
Issue: https://issues.redhat.com/browse/OSDOCS-16547
No QE required as this is just a text substitution. Previews are not listed as there are too many, but the preview is here:
https://100535--ocpdocs-pr.netlify.app/
Partner PR to #100525