-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CNV#67095: Docs on setup vGPU reach a dead end on step 3 of mdev creation #100595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Thu Oct 16 20:25:28 - Prow CI generated the docs preview: |
512a6a5
to
0b83b1f
Compare
441d8f8
to
490068f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits, otherwise LGTM!
ca87e2e
to
87aaab2
Compare
@ousleyp: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
LGTM |
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.20 |
@ousleyp: new pull request created: #100752 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ousleyp: new pull request created: #100753 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.19+
Issue: CNV-67095
Link to docs preview: https://100595--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/advanced_vm_management/virt-configuring-virtual-gpus.html#virt-creating-exposing-mediated-devices_virt-configuring-virtual-gpus
QE review:
Additional information: Taking this work over; original PR was #99158; QE approved that PR; content was peer reviewed separately by me/Shikha on #100376; I am applying peer review fixes; this includes a bit of reworking so I'm seeking additional reviews before merge
FYI @akri3i and @kbidarkar - please do a quick re-review if possible. thank you :)