Skip to content

[OSDOCS#16557] remove unused modules from main #100596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

[OSDOCS#16557] remove unused modules from main #100596

merged 1 commit into from
Oct 27, 2025

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Oct 16, 2025 •
edited
Loading

Version(s):

Issue: https://issues.redhat.com/browse/OSDOCS-16557

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@maxwelldb maxwelldb added this to the Continuous Release milestone Oct 16, 2025
@maxwelldb maxwelldb self-assigned this Oct 16, 2025
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 16, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 16, 2025 •
edited
Loading

🤖 Fri Oct 24 21:05:24 - Prow CI generated the docs preview:

https://100596--ocpdocs-pr.netlify.app/
https://100596--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_configuration/mco-coreos-layering.html
https://100596--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/cluster_api_machine_management/cluster_api_provider_configurations/cluster-api-config-options-aws.html
https://100596--ocpdocs-pr.netlify.app/openshift-enterprise/latest/machine_management/cluster_api_machine_management/cluster_api_provider_configurations/cluster-api-config-options-bare-metal.html

@maxwelldb maxwelldb force-pushed the main-unused-modules branch from a423ba6 to 3689f10 Compare October 16, 2025 01:44
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 16, 2025

/retest

@maxwelldb maxwelldb changed the title [OSDOCS#TBD] remove unused modules from main [OSDOCS#16557] remove unused modules from main Oct 17, 2025
@dfitzmau
Copy link
Contributor

dfitzmau commented Oct 20, 2025 •
edited
Loading

Networking LGTM. I'm asssuming a cherry-pick to 4.20 from this PR?

@bscott-rh
Copy link
Contributor

bscott-rh commented Oct 20, 2025

Install LGTM

lahinson
lahinson reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mburke5678
Copy link
Contributor

mburke5678 commented Oct 23, 2025

Can we retain https://github.com/openshift/openshift-docs/blob/main/modules/coreos-layering-configuring-on-extensions.adoc? It might be needed either now or in the future. Looking into it.

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 23, 2025

@mburke5678 Just for posterity: #100602 (comment)

@maxwelldb maxwelldb added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 23, 2025
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 24, 2025

@mburke5678 Same about https://github.com/openshift/openshift-docs/blob/main/modules/coreos-layering-configuring-on-extensions.adoc here as with the 4.18 PR?

@maxwelldb maxwelldb requested a review from mburke5678 October 24, 2025 12:39
@mburke5678
Copy link
Contributor

mburke5678 commented Oct 24, 2025 •
edited
Loading

@maxwelldb

Same about https://github.com/openshift/openshift-docs/blob/main/modules/coreos-layering-configuring-on-extensions.adoc here as with the 4.18 PR?

Yep. Thanks for asking!

@michaelryanpeter michaelryanpeter added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 24, 2025
@michaelryanpeter
Copy link
Contributor

michaelryanpeter commented Oct 24, 2025

It looks like the CI missed some errors. I'm going to remove the merge labels for now. 4.17 to 4.14 were clean though 🥳

@maxwelldb maxwelldb force-pushed the main-unused-modules branch from 3689f10 to bc48a35 Compare October 24, 2025 20:58
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2025

@maxwelldb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 24, 2025

Builds clean locally for me.

@maxwelldb maxwelldb added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 24, 2025
@michaelryanpeter michaelryanpeter added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 27, 2025
michaelryanpeter
michaelryanpeter reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after running the prow checks locally

@michaelryanpeter michaelryanpeter merged commit 3d106c7 into openshift:main Oct 27, 2025
2 checks passed
@maxwelldb maxwelldb mentioned this pull request Oct 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

@lahinson lahinson lahinson left review comments

@mburke5678 mburke5678 mburke5678 approved these changes

Assignees

@maxwelldb maxwelldb

Labels

merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@maxwelldb @ocpdocs-previewbot @dfitzmau @bscott-rh @mburke5678 @michaelryanpeter @lahinson