-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1806: Tailored Network Policies for Loki Operator #100718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-1806: Tailored Network Policies for Loki Operator #100718
Conversation
|
@theashiot: This pull request references OBSDOCS-1806 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Mon Nov 10 13:40:55 - Prow CI generated the docs preview: |
9d847d4 to
a8cab9a
Compare
modules/integrating-loki-network-policy-with-external-systems.adoc
Outdated
Show resolved
Hide resolved
a8cab9a to
4197a89
Compare
|
Thanks, @JoaoBraveCoding for the review! I've made all the changes. Mind having another look? best, |
|
@theashiot: This pull request references OBSDOCS-1806 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4197a89 to
ee34e10
Compare
ee34e10 to
421bfab
Compare
modules/integrating-loki-network-policy-with-external-systems.adoc
Outdated
Show resolved
Hide resolved
421bfab to
f288e6d
Compare
|
Thanks, @kabirbhartiRH for the review! I've made the required change, mind having a look? best, |
|
LGTM |
|
Thanks, @kabirbhartiRH! best, |
|
@theashiot: This pull request references OBSDOCS-1806 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gabriel-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - some minor comments
modules/integrating-loki-network-policy-with-external-systems.adoc
Outdated
Show resolved
Hide resolved
modules/integrating-loki-network-policy-with-external-systems.adoc
Outdated
Show resolved
Hide resolved
f288e6d to
87d2729
Compare
|
Thanks, @gabriel-rh for the review! I've made all the changes. best, |
|
@theashiot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ec43fa1
into
openshift:standalone-logging-docs-main
|
/cherrypick standalone-logging-docs-6.4 |
|
@briandooley: new pull request created: #102106 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 6.4
Issue: https://issues.redhat.com/browse/OBSDOCS-1806
Link to docs preview: https://100718--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html#loki-network-policies-for-added-security_configuring-the-log-store
QE review:
Additional information: