-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc #100820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dfitzmau: This pull request references Jira Issue OCPBUGS-51298, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
56618f9 to
f72ea19
Compare
|
@dfitzmau: This pull request references Jira Issue OCPBUGS-51298, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f72ea19 to
afe15d4
Compare
|
LGTM |
| When installing a cluster on shared Virtual Private Cloud (VPC) infrastructure where you need to manually create credentials, grant the `compute.subnetworks.use` permission to the credentials that the Machine API Operator uses on the host VPC project. | ||
| ==== | ||
|
|
||
| You must apply the minimum roles required for a standard installation as listed in the "Required GCP permissions for installer-provisioned infrastructure" section to the service project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than adding such paragraph, how about updating subsequent IMPORTANT statements like below?
You can use granular permissions for a Cloud Credential Operator that operates in either Manual or Mint mode (please refer to 2.5.2. Required Google Cloud permissions for installer-provisioned infrastructure). You cannot use granular permissions in Passthrough mode (please refer to 2.5.1. Required Google Cloud roles).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
| You must apply the minimum roles required for a standard installation as listed above, to the service project. | ||
| [IMPORTANT] | ||
| ==== | ||
| When installing a cluster on shared Virtual Private Cloud (VPC) infrastructure where you need to manually create credentials, grant the `compute.subnetworks.use` permission to the credentials that the Machine API Operator uses on the host VPC project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestion:
When installing a cluster to a shared Virtual Private Cloud (VPC) infrastructure, and you want to manually create credentials, grant the compute.subnetworks.use permission on the host project to the credentials that the Machine API Operator uses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
ed1efa9 to
275342c
Compare
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@dfitzmau: Jira Issue OCPBUGS-51298: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-51298 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.15 |
|
@dfitzmau: new pull request created: #101935 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #101937 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.18": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.19": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.17": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.16": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.15": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.15+
Issue:
OCPBUGS-51298
Link to docs preview: