Skip to content

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Oct 21, 2025

Version(s):
4.15+

Issue:
OCPBUGS-51298

Link to docs preview:

  • SME has approved this change (Patrick Dillon).
  • QE has approved this change (Jianli Wei).

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 21, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-51298, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.15+

Issue:
OCPBUGS-51298

Link to docs preview:

  • SME has approved this change.
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau added branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 and removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 21, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2025
@dfitzmau dfitzmau force-pushed the OCPBUGS-51298 branch 2 times, most recently from 56618f9 to f72ea19 Compare October 21, 2025 11:12
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Oct 21, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-51298, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.15+

Issue:
OCPBUGS-51298

Link to docs preview:

  • SME has approved this change (Patrick Dillon).
  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 21, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 21, 2025

@patrickdillon
Copy link
Contributor

LGTM

When installing a cluster on shared Virtual Private Cloud (VPC) infrastructure where you need to manually create credentials, grant the `compute.subnetworks.use` permission to the credentials that the Machine API Operator uses on the host VPC project.
====

You must apply the minimum roles required for a standard installation as listed in the "Required GCP permissions for installer-provisioned infrastructure" section to the service project.
Copy link

@jianli-wei jianli-wei Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding such paragraph, how about updating subsequent IMPORTANT statements like below?

You can use granular permissions for a Cloud Credential Operator that operates in either Manual or Mint mode (please refer to 2.5.2. Required Google Cloud permissions for installer-provisioned infrastructure). You cannot use granular permissions in Passthrough mode (please refer to 2.5.1. Required Google Cloud roles).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

You must apply the minimum roles required for a standard installation as listed above, to the service project.
[IMPORTANT]
====
When installing a cluster on shared Virtual Private Cloud (VPC) infrastructure where you need to manually create credentials, grant the `compute.subnetworks.use` permission to the credentials that the Machine API Operator uses on the host VPC project.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion:
When installing a cluster to a shared Virtual Private Cloud (VPC) infrastructure, and you want to manually create credentials, grant the compute.subnetworks.use permission on the host project to the credentials that the Machine API Operator uses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 6, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit 707a9b0 into openshift:main Nov 6, 2025
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-51298: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-51298 has been moved to the MODIFIED state.

In response to this:

Version(s):
4.15+

Issue:
OCPBUGS-51298

Link to docs preview:

  • SME has approved this change (Patrick Dillon).
  • QE has approved this change (Jianli Wei).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Nov 6, 2025

/cherrypick enterprise-4.21

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Nov 6, 2025

/cherrypick enterprise-4.20

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Nov 6, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Nov 6, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Nov 6, 2025

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Nov 6, 2025

/cherrypick enterprise-4.16

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Nov 6, 2025

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #101935

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: new pull request created: #101937

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.18":

Applying: OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc
Using index info to reconstruct a base tree...
M	modules/minimum-required-permissions-ipi-gcp-xpn.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/minimum-required-permissions-ipi-gcp-xpn.adoc
CONFLICT (content): Merge conflict in modules/minimum-required-permissions-ipi-gcp-xpn.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.19":

Applying: OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc
Using index info to reconstruct a base tree...
M	modules/minimum-required-permissions-ipi-gcp-xpn.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/minimum-required-permissions-ipi-gcp-xpn.adoc
CONFLICT (content): Merge conflict in modules/minimum-required-permissions-ipi-gcp-xpn.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.17":

Applying: OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc
Using index info to reconstruct a base tree...
M	modules/minimum-required-permissions-ipi-gcp-xpn.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/minimum-required-permissions-ipi-gcp-xpn.adoc
CONFLICT (content): Merge conflict in modules/minimum-required-permissions-ipi-gcp-xpn.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.16":

Applying: OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc
Using index info to reconstruct a base tree...
M	modules/manually-create-iam-ibm-cloud.adoc
M	modules/minimum-required-permissions-ipi-gcp-xpn.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/minimum-required-permissions-ipi-gcp-xpn.adoc
CONFLICT (content): Merge conflict in modules/minimum-required-permissions-ipi-gcp-xpn.adoc
Auto-merging modules/manually-create-iam-ibm-cloud.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@dfitzmau: #100820 failed to apply on top of branch "enterprise-4.15":

Applying: OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc
Using index info to reconstruct a base tree...
M	modules/manually-create-iam-ibm-cloud.adoc
M	modules/minimum-required-permissions-ipi-gcp-xpn.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/minimum-required-permissions-ipi-gcp-xpn.adoc
CONFLICT (content): Merge conflict in modules/minimum-required-permissions-ipi-gcp-xpn.adoc
Auto-merging modules/manually-create-iam-ibm-cloud.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-51298: Added VPC note to manually-create-iam-ibm-cloud.adoc

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-merge size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants