-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSM-11013 [DOCS] Review and update Egress docs for ambient mode #100884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-11013 [DOCS] Review and update Egress docs for ambient mode #100884
Conversation
|
🤖 Mon Oct 27 12:02:13 - Prow CI generated the docs preview: |
|
/label service-mesh |
cam-garrison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit picks and a structuring request
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
sridhargaddam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass...
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-directing-egress-traffic-through-a-gateway-using-kubernetes-gateway-api.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from executions pov:
With @sridhargaddam fixes:
oc get gateways.gateway.networking.k8s.io waypoint -n egress-gateway
->
NAME CLASS ADDRESS PROGRAMMED AGE
waypoint istio-waypoint 172.30.227.148 True 9s
And test-pod curl command execution left log in ztunnel pod:
2025-10-24T08:08:35.242159Z info access connection complete src.addr=[fd01:0:0:5::b0]:56288 src.workload="test-pod" src.namespace="egress-gateway" src.identity="spiffe://cluster.local/ns/egress-gateway/sa/default" dst.addr=[fd01:0:0:5::af]:15008 dst.hbone_addr=[2001:2::2]:80 dst.service="httpbin.org" dst.workload="waypoint-5b668759d5-vrnx8" dst.namespace="egress-gateway" dst.identity="spiffe://cluster.local/ns/egress-gateway/sa/waypoint" direction="outbound" bytes_sent=78 bytes_recv=540 duration="957ms"
Tested with DualStack/IPv6/ROSA clusters
However, small comment on extra "+" in text
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
sridhargaddam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the review comments @shreyasiddhartha. Please take a look at the latest comment from Mikhail and we should be good.
3daba95 to
1e8a560
Compare
modules/ossm-about-directing-egress-traffic-through-a-gateway.adoc
Outdated
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Show resolved
Hide resolved
...les/ossm-directing-egress-traffic-through-a-gateway-kubernetes-gateway-api-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
|
Hey @shreyasiddhartha, good job on the PR. Please view the few comments I've provided you here. Do reach out if you need help. Thanks!! |
8cfa5ea to
b67dfe9
Compare
|
@shreyasiddhartha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick service-mesh-docs-3.2 |
|
@rh-tokeefe: new pull request created: #101090 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change type: Doc update; Review and update Egress docs for ambient mode
Doc JIRA: https://issues.redhat.com/browse/OSSM-11013
Fix Version: service-mesh-docs-main and service-mesh-docs-3.2
Doc Preview: https://100884--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-directing-outbound-traffic.html
SME Review/QE Review: @cam-garrison @sridhargaddam @ctartici @unsortedhashsets
Peer Review: @Dhruv-Soni11