Skip to content

Conversation

@shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Oct 22, 2025

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 22, 2025

🤖 Mon Oct 27 12:02:13 - Prow CI generated the docs preview:

https://100884--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-directing-outbound-traffic.html

@shreyasiddhartha
Copy link
Contributor Author

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label Oct 22, 2025
Copy link

@cam-garrison cam-garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit picks and a structuring request

Copy link

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass...

Copy link

@unsortedhashsets unsortedhashsets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from executions pov:

With @sridhargaddam fixes:

oc get gateways.gateway.networking.k8s.io waypoint -n egress-gateway

->

NAME       CLASS            ADDRESS          PROGRAMMED   AGE
waypoint   istio-waypoint   172.30.227.148   True         9s

And test-pod curl command execution left log in ztunnel pod:

2025-10-24T08:08:35.242159Z info access connection complete src.addr=[fd01:0:0:5::b0]:56288 src.workload="test-pod" src.namespace="egress-gateway" src.identity="spiffe://cluster.local/ns/egress-gateway/sa/default" dst.addr=[fd01:0:0:5::af]:15008 dst.hbone_addr=[2001:2::2]:80 dst.service="httpbin.org" dst.workload="waypoint-5b668759d5-vrnx8" dst.namespace="egress-gateway" dst.identity="spiffe://cluster.local/ns/egress-gateway/sa/waypoint" direction="outbound" bytes_sent=78 bytes_recv=540 duration="957ms"

Tested with DualStack/IPv6/ROSA clusters

However, small comment on extra "+" in text

Copy link

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the review comments @shreyasiddhartha. Please take a look at the latest comment from Mikhail and we should be good.

@shreyasiddhartha shreyasiddhartha force-pushed the OSSM-11013 branch 2 times, most recently from 3daba95 to 1e8a560 Compare October 27, 2025 06:20
@Dhruv-Soni11
Copy link
Contributor

Hey @shreyasiddhartha, good job on the PR. Please view the few comments I've provided you here. Do reach out if you need help. Thanks!!

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rh-tokeefe rh-tokeefe merged commit 30abaf8 into openshift:service-mesh-docs-main Oct 27, 2025
2 checks passed
@rh-tokeefe
Copy link
Contributor

/cherrypick service-mesh-docs-3.2

@openshift-cherrypick-robot

@rh-tokeefe: new pull request created: #101090

In response to this:

/cherrypick service-mesh-docs-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants