-
Couldn't load subscription status.
- Fork 1.8k
CTEditor-z-to-the-r: Add missing module type tags to files starting w… #101051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Wed Oct 29 10:03:41 - Prow CI generated the docs preview: |
modules/storage-persistent-storage-iscsi-enforcing-disk-quota.adoc
Outdated
Show resolved
Hide resolved
ea8e30f to
8f24d13
Compare
aec03c6 to
ba7970e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work, what a pain 😅
Some of these are pretty squishy, especially wrt to formatting that makes their content type unclear/debatable. Some should probably be modularized more fully to truly match the content type. All of that to say: please take these suggestions as suggestions, and if you disagree on any, you're probably as right as any of us until we have more clear standards on some of these types of topics 🤓
/remove-label merge-review-in-progress
/remove-label merge-review-needed
rest_api/authorization_apis/tokenreview-oauth-openshift-io-v1.adoc
Outdated
Show resolved
Hide resolved
|
@jeana-redhat: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ba7970e to
1223565
Compare
1223565 to
4eb68d6
Compare
| + | ||
| .. *During the build configuration stage*, a build pod is used to create an application container image from a base image and application source code. | ||
| + | ||
| .. *During the deployment configuration stage*, a deployment pod is used to deploy application pods from the application container image that was built in the build configuration stage. The deployment pod also deploys other resources such as services and routes. The deployment configuration begins after the build configuration succeeds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] Vale.Avoid: Avoid using 'deployment configuration'.
| + | ||
| .. *During the build configuration stage*, a build pod is used to create an application container image from a base image and application source code. | ||
| + | ||
| .. *During the deployment configuration stage*, a deployment pod is used to deploy application pods from the application container image that was built in the build configuration stage. The deployment pod also deploys other resources such as services and routes. The deployment configuration begins after the build configuration succeeds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'deployment' rather than 'deployment configuration'. For more information, see RedHat.TermsErrors.
| + | ||
| .. *During the build configuration stage*, a build pod is used to create an application container image from a base image and application source code. | ||
| + | ||
| .. *During the deployment configuration stage*, a deployment pod is used to deploy application pods from the application container image that was built in the build configuration stage. The deployment pod also deploys other resources such as services and routes. The deployment configuration begins after the build configuration succeeds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] Vale.Avoid: Avoid using 'deployment configuration'.
| + | ||
| .. *During the deployment configuration stage*, a deployment pod is used to deploy application pods from the application container image that was built in the build configuration stage. The deployment pod also deploys other resources such as services and routes. The deployment configuration begins after the build configuration succeeds. | ||
| + | ||
| .. *After the deployment pod has started the application pods*, application failures can occur within the running application pods. For instance, an application might not behave as expected even though the application pods are in a `Running` state. In this scenario, you can access running application pods to investigate application failures within a pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'for example' rather than 'For instance'. For more information, see RedHat.TermsErrors.
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.14 |
|
@dfitzmau: new pull request created: #101287 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #101288 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #101289 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #101290 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #101051 failed to apply on top of branch "enterprise-4.17": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #101051 failed to apply on top of branch "enterprise-4.16": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #101051 failed to apply on top of branch "enterprise-4.15": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: #101051 failed to apply on top of branch "enterprise-4.14": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR adds CONTENT TYPE tags to modules that are missing the tag.
Version(s):
4.12+
Issue:
AsciiDoc Content Type Editor
AsciiDoc Content Type Editor-GH
Add. Info: