-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSM-11012 [DOCS] Review and update Ingress docs for ambient mode #101087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-11012 [DOCS] Review and update Ingress docs for ambient mode #101087
Conversation
9eca3f9 to
a44637a
Compare
3c2c2f2 to
a555e28
Compare
|
/label service-mesh |
sridhargaddam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shreyasiddhartha.
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api.adoc
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-about-configuring-a-gateway-to-accept-ingress-traffic.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api.adoc
Show resolved
Hide resolved
sridhargaddam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shreyasiddhartha
50c35c4 to
2346d6b
Compare
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api.adoc
Show resolved
Hide resolved
kaldesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really well written, good job! :)
Just a few minor suggestions from my side that you might want to consider.
Peer review for this PR is complete.
e17b3c4 to
bf4939b
Compare
|
@shreyasiddhartha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
gabriel-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/cherrypick service-mesh-docs-3.2 |
|
@gabriel-rh: new pull request created: #101664 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change type: Doc update; Review and update Ingress docs for ambient mode
Doc JIRA: https://issues.redhat.com/browse/OSSM-11012
Fix Version: service-mesh-docs-main and service-mesh-docs-3.2
Doc Preview: https://101087--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-getting-traffic-into-a-mesh
SME Review/QE Review: @cam-garrison @sridhargaddam
Peer Review: @kaldesai