Skip to content

Conversation

@shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Oct 27, 2025

Change type: Doc update; Review and update Ingress docs for ambient mode

Doc JIRA: https://issues.redhat.com/browse/OSSM-11012

Fix Version: service-mesh-docs-main and service-mesh-docs-3.2

Doc Preview: https://101087--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-getting-traffic-into-a-mesh

SME Review/QE Review: @cam-garrison @sridhargaddam
Peer Review: @kaldesai

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2025
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 28, 2025
@shreyasiddhartha
Copy link
Contributor Author

/label service-mesh

@openshift-ci openshift-ci bot added service-mesh Label for all Service Mesh PRs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2025
Copy link

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well written, good job! :)
Just a few minor suggestions from my side that you might want to consider.

Peer review for this PR is complete.

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@gabriel-rh gabriel-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabriel-rh gabriel-rh merged commit 29335e9 into openshift:service-mesh-docs-main Nov 4, 2025
2 checks passed
@gabriel-rh
Copy link
Contributor

/cherrypick service-mesh-docs-3.2

@openshift-cherrypick-robot

@gabriel-rh: new pull request created: #101664

In response to this:

/cherrypick service-mesh-docs-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-mesh Label for all Service Mesh PRs size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants