Skip to content

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Oct 28, 2025

Manual CP of #100488

As our CI isn't always properly vetting changes like this, for the record, full local asciibinder build succeeded 10/28.

Building all distributions.
...
WARN: The /tmp/_topic_map.yml20251028-1-ecmzq3 file on branch 'unused-snippets-4.21' references 1067 nonexistent topics. Set logging to 'debug' for details.
WARN: Branch unused-snippets-4.21 includes 8449 files that are not referenced in the /tmp/_topic_map.yml20251028-1-fpcsde file. Set logging to 'debug' for details.
Building OpenShift Container Platform for branch 'unused-snippets-4.21'
asciidoctor: WARNING: modules/virt-aws-bm.adoc: line 20: section title out of sequence: expected level 1, got level 2
asciidoctor: WARNING: preparing-cluster-for-virt.adoc: line 119: section title out of sequence: expected level 1, got level 2
asciidoctor: WARNING: modules/virt-aws-bm.adoc: line 20: section title out of sequence: expected level 1, got level 2
asciidoctor: WARNING: preparing-cluster-for-virt.adoc: line 119: section title out of sequence: expected level 1, got level 2
All builds completed.

@maxwelldb maxwelldb added this to the Continuous Release milestone Oct 28, 2025
@maxwelldb maxwelldb self-assigned this Oct 28, 2025
@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 28, 2025
@maxwelldb maxwelldb force-pushed the unused-snippets-4.21 branch from 1d5b03a to 347ea2b Compare October 28, 2025 13:53
@maxwelldb maxwelldb added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 28, 2025
@ocpdocs-previewbot
Copy link

🤖 Tue Oct 28 14:04:23 - Prow CI generated the docs preview:

https://101155--ocpdocs-pr.netlify.app/

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2025

@maxwelldb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skopacz1 skopacz1 added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Oct 28, 2025
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how I am supposed to really review this, so I will give a hesitant LGTM as I now associate my name with any potential build failures 😂

(On a serious note, commits are squashed, the branch looks right, and the files deleted seem reasonable)

@skopacz1 skopacz1 added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Oct 28, 2025
@maxwelldb maxwelldb merged commit 5c8299c into openshift:enterprise-4.21 Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.21 ok-to-merge size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants