OLS-2240: run vale checks on install assembly #101211
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rh-tokeefe: This pull request references OLS-2240 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/S
|
🤖 Wed Oct 29 16:13:27 - Prow CI generated the docs preview: |
|
@rh-tokeefe: This pull request references OLS-2240 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rh-tokeefe: This pull request references OLS-2240 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
gwynnemonahan
left a comment
gwynnemonahan
left a comment
There was a problem hiding this comment.
One comment with a couple of suggestions to fix the short description so it meets current guidelines.
| = About subscription requirements | ||
|
|
||
| [role="_abstract"] | ||
| {ols-official} requires an active and valid subscription to one of the following products: |
There was a problem hiding this comment.
This is an incomplete sentence, and ends with a colon instead of a period. Maybe something like ....
"{ols-official} requires a valid and active subscription to one of the listed OpenShift products."
Or maybe "Review the valid and active subscriptions required to use {ols-official}".
I'm not 100% sure of the context, so not sure which option would work best, or if perhaps a better option can be written.
openshift-ci
bot
added
size/M
|
@rh-tokeefe: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick lightspeed-docs-1.0 |
|
@rh-tokeefe: new pull request created: #101362 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Affects:
lightspeed-main
lightspeed-docs-1.0
PR must be CP'd back to the lightspeed-docs-1.0 branch.
Version(s): 1.0
Issue: https://issues.redhat.com/browse/OLS-2240
Link to docs preview:
QE review:
Additional information: