-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[OSDOCS-16995]: Adding content types to modules: F-I #101242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSDOCS-16995]: Adding content types to modules: F-I #101242
Conversation
|
🤖 Wed Oct 29 16:47:37 - Prow CI generated the docs preview: |
b383ae5 to
84eec1f
Compare
84eec1f to
593e7ff
Compare
593e7ff to
ac0c1f8
Compare
ac0c1f8 to
00b022d
Compare
ShaunaDiaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // | ||
| // * security/file_integrity_operator/file-integrity-operator-understanding.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW this looks like reference to me.
| // | ||
| // * security/file_integrity_operator/file-integrity-operator-understanding.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably call this Reference as well.
| // | ||
| // * security/file_integrity_operator/file-integrity-operator-understanding.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably call this Reference as well.
| // | ||
| // * security/file_integrity_operator/file-integrity-operator-configuring.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://github.com/redhat-documentation/modular-docs/blob/main/modular-docs-manual/files/TEMPLATE_CONCEPT_concept-explanation.adoc, there are not supposed to be gerunds in concept modules. Don't know if this is a DITA problem. Likely beyond the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right --there are not supposed to be gerunds in concept modules. You are also right that changing the title is beyond the scope of this PR.
| // | ||
| // * installing/installing_azure_stack_hub/installing-azure-stack-hub-user-infra.adoc | ||
|
|
||
| :_mod-docs-content-type: CONCEPT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reference IMHO
00b022d to
46b859c
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.15 |
|
@lahinson: new pull request created: #101319 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.14 |
|
@lahinson: new pull request created: #101320 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #101321 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #101322 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #101323 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: #101242 failed to apply on top of branch "enterprise-4.16": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: #101242 failed to apply on top of branch "enterprise-4.15": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: #101242 failed to apply on top of branch "enterprise-4.14": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s): 4.14+
Issue: https://issues.redhat.com/browse/OSDOCS-16695
Link to docs preview:
QE review:
N/A for this PR
Additional information: This PR is part of the tiger team work to prepare content for migration to DITA.