Skip to content

Conversation

@abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Oct 28, 2025

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@abrennan89: This pull request references CNV-56853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):

Issue:
https://issues.redhat.com/browse/CNV-56853

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2025
@abrennan89 abrennan89 changed the title CNV-56853: Add RBAC permissions to allow users to manage VMs through the web console [WIP] CNV-56853: Add RBAC permissions to allow users to manage VMs through the web console Oct 28, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 3, 2025

@abrennan89: This pull request references CNV-56853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):

Issue:
https://issues.redhat.com/browse/CNV-56853

Link to docs preview:
https://101259--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-controlling-vm-states.html#virt-configure-rbac-console-subresources-api_virt-controlling-vm-states

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 changed the title [WIP] CNV-56853: Add RBAC permissions to allow users to manage VMs through the web console CNV-56853: Add RBAC permissions to allow users to manage VMs through the web console Nov 3, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
@abrennan89 abrennan89 force-pushed the CNV-56853 branch 2 times, most recently from 2abe3c8 to 05b6a7c Compare November 3, 2025 18:07
@abrennan89 abrennan89 force-pushed the CNV-56853 branch 3 times, most recently from 7764ee4 to 21a6dc9 Compare November 6, 2025 14:25
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2025

@abrennan89: This pull request references CNV-56853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):

Issue:
https://issues.redhat.com/browse/CNV-56853

Link to docs preview:
https://101259--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-controlling-vm-states.html#virt-configure-rbac-console-subresources-api_virt-controlling-vm-states

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 removed the request for review from lkladnit November 6, 2025 14:27
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 6, 2025

@abrennan89: This pull request references CNV-56853 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Version(s):
4.16+

Issue:
https://issues.redhat.com/browse/CNV-56853

Link to docs preview:
https://101259--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/managing_vms/virt-controlling-vm-states.html#virt-configure-rbac-console-subresources-api_virt-controlling-vm-states

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor Author

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update the example headers

@abrennan89 abrennan89 force-pushed the CNV-56853 branch 2 times, most recently from bfce961 to 11e7d2d Compare November 7, 2025 16:08
Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tiniest of nits and a couple of comments; really great work!

@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2025

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@abrennan89 abrennan89 merged commit de2d6fd into openshift:main Nov 10, 2025
2 checks passed
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.16

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.17

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.18

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.19

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.20

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.21

@openshift-cherrypick-robot

@abrennan89: #101259 failed to apply on top of branch "enterprise-4.16":

Applying: CNV-56853: Add RBAC permissions to allow users to manage VMs through the console
Using index info to reconstruct a base tree...
A	virt/managing_vms/virt-controlling-vm-states.adoc
Falling back to patching base and 3-way merge...
Auto-merging virt/virtual_machines/virt-controlling-vm-states.adoc
CONFLICT (content): Merge conflict in virt/virtual_machines/virt-controlling-vm-states.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-56853: Add RBAC permissions to allow users to manage VMs through the console

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: #101259 failed to apply on top of branch "enterprise-4.17":

Applying: CNV-56853: Add RBAC permissions to allow users to manage VMs through the console
Using index info to reconstruct a base tree...
A	virt/managing_vms/virt-controlling-vm-states.adoc
Falling back to patching base and 3-way merge...
Auto-merging virt/virtual_machines/virt-controlling-vm-states.adoc
CONFLICT (content): Merge conflict in virt/virtual_machines/virt-controlling-vm-states.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-56853: Add RBAC permissions to allow users to manage VMs through the console

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: #101259 failed to apply on top of branch "enterprise-4.18":

Applying: CNV-56853: Add RBAC permissions to allow users to manage VMs through the console
Using index info to reconstruct a base tree...
M	virt/managing_vms/virt-controlling-vm-states.adoc
Falling back to patching base and 3-way merge...
Auto-merging virt/managing_vms/virt-controlling-vm-states.adoc
CONFLICT (content): Merge conflict in virt/managing_vms/virt-controlling-vm-states.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 CNV-56853: Add RBAC permissions to allow users to manage VMs through the console

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #102139

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #102140

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #102141

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants