-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSM-11032 [DOCS] Modify upgrade procedure for ambient mode #101283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-11032 [DOCS] Modify upgrade procedure for ambient mode #101283
Conversation
|
🤖 Fri Nov 07 11:52:47 - Prow CI generated the docs preview: |
0c7c9ba to
0d7e5f7
Compare
|
/label service-mesh |
|
@shreyasiddhartha : Doc Preview: https://101283--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-update-strategies, this page is broken |
|
Doc Preview: https://101283--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-update-strategies This page is not working |
Updated the link. Sorry for that. |
sridhargaddam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shreyasiddhartha.
modules/ossm-updating-waypoint-proxies-with-inplace-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-inplace-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-revisionbased-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-revisionbased-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-revisionbased-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-verifying-l7-features-with-authorization-policies.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-revisionbased-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-revisionbased-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-verifying-l7-features-with-authorization-policies.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-verifying-l7-features-with-authorization-policies.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-inplace-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-inplace-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-inplace-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-inplace-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-verifying-l7-features-with-authorization-policies.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-updating-waypoint-proxies-with-inplace-strategy.adoc
Outdated
Show resolved
Hide resolved
fjglira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small comment
fjglira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the examples. I found them in the previous ambient documentation in the sail repository
modules/ossm-updating-waypoint-proxies-with-revisionbased-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-verifying-l7-features-with-authorization-policies.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-verifying-l7-features-with-authorization-policies.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-verifying-l7-features-with-authorization-policies.adoc
Outdated
Show resolved
Hide resolved
fjglira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fjglira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I found an error while checking the web view
fjglira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small more comment
update/ossm-updating-openshift-service-mesh-in-ambient-mode.adoc
Outdated
Show resolved
Hide resolved
fjglira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
modules/ossm-updating-waypoint-proxies-with-revisionbased-strategy.adoc
Outdated
Show resolved
Hide resolved
modules/ossm-verifying-l7-features-with-authorization-policies.adoc
Outdated
Show resolved
Hide resolved
kaldesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done :)
Some minor suggestions otherwise, your changes LGTM
Peer review is complete
4ebe63c to
91539ef
Compare
91539ef to
4df3cfd
Compare
|
@shreyasiddhartha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick service-mesh-docs-3.2 |
|
@briandooley: new pull request created: #101988 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change type: Doc update; Review and update Egress docs for ambient mode
Doc JIRA: https://issues.redhat.com/browse/OSSM-11032
Fix Version: service-mesh-docs-main and service-mesh-docs-3.2
Doc Preview: https://101283--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-about-updating-openshift-service-mesh
SME Review/QE Review: @pbajjuri20 @rafaelvzago @fjglira @sridhargaddam
Peer Review: @kaldesai