Skip to content

Conversation

@shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Oct 29, 2025

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 29, 2025

🤖 Fri Nov 07 11:52:47 - Prow CI generated the docs preview:
https://101283--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2025
@shreyasiddhartha
Copy link
Contributor Author

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label Oct 30, 2025
@pbajjuri20
Copy link

@pbajjuri20
Copy link

Doc Preview: https://101283--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-update-strategies

This page is not working

@shreyasiddhartha
Copy link
Contributor Author

Doc Preview: https://101283--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/update/ossm-update-strategies

This page is not working

Updated the link. Sorry for that.

Copy link

@sridhargaddam sridhargaddam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small comment

Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the examples. I found them in the previous ambient documentation in the sail repository

Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I found an error while checking the web view

Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small more comment

Copy link

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@kaldesai kaldesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done :)
Some minor suggestions otherwise, your changes LGTM
Peer review is complete

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@briandooley briandooley merged commit d13e8f0 into openshift:service-mesh-docs-main Nov 7, 2025
2 checks passed
@briandooley
Copy link
Contributor

/cherrypick service-mesh-docs-3.2

@openshift-cherrypick-robot

@briandooley: new pull request created: #101988

In response to this:

/cherrypick service-mesh-docs-3.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants