Skip to content

Conversation

@rohennes
Copy link
Contributor

@rohennes rohennes commented Oct 29, 2025

TELCODOCS-2529: In IBI and IBU, IPv6/4 now both possible as primary address fam in dual-stack networking

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2529

Link to docs preview:

QE review:

  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2025

@rohennes: This pull request references TELCODOCS-2529 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

TELCODOCS-2529: In IBI and IBU, IPv6/4 now both possible as primary address fam in dual-stack networking

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2529

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2025

@rohennes: This pull request references TELCODOCS-2529 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

TELCODOCS-2529: In IBI and IBU, IPv6/4 now both possible as primary address fam in dual-stack networking

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2529

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2025
<4> Specify the hostname for the cluster.
<5> Specify the name of the `ClusterImageSet` resource you used to define the container release images to use for deployment.
<6> Specify the public Classless Inter-Domain Routing (CIDR) of the external network. For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format. Regardless of the list order, the IPv4 family becomes the primary address family.
<6> Specify the public Classless Inter-Domain Routing (CIDR) of the external network. For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add that the first address is the primary and it must match the primary IP stack of the seed

sshKey: 'ssh-rsa <your_ssh_pub_key>'
----
<1> For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format. You must specify the IPv4 family as the primary address family by defining the IPv4 address as the first item in the list.
<1> For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sam comment as above

|`bareMetalHostRef`|`string`| Specify the `bareMetalHost` resource to use for the cluster deployment

|`machineNetwork`|`string`| Specify the public Classless Inter-Domain Routing (CIDR) of the external network. For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format. Regardless of the list order, the IPv4 family becomes the primary address family.
|`machineNetwork`|`string`| Specify the public Classless Inter-Domain Routing (CIDR) of the external network. For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

|`bareMetalHostRef`|`string`| Specify the `bareMetalHost` resource to use for the cluster deployment

|`machineNetwork`|`string`| Specify the public Classless Inter-Domain Routing (CIDR) of the external network. For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format. Regardless of the list order, the IPv4 family becomes the primary address family.
|`machineNetwork`|`string`| Specify the public Classless Inter-Domain Routing (CIDR) of the external network. For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format. The first CIDR in the list is the primary address family and must match the primary address family of the seed cluster.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|`machineNetwork`|`string`| Specify the public Classless Inter-Domain Routing (CIDR) of the external network. For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format. The first CIDR in the list is the primary address family and must match the primary address family of the seed cluster.
|`machineNetworks`|`string`| Specify the public Classless Inter-Domain Routing (CIDR) of the external network. For dual-stack networking, you can specify both IPv4 and IPv6 CIDRs using a list format. The first CIDR in the list is the primary address family and must match the primary address family of the seed cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot!! Updated

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

@rohennes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2025

@rohennes: This pull request references TELCODOCS-2529 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20" instead.

In response to this:

TELCODOCS-2529: In IBI and IBU, IPv6/4 now both possible as primary address fam in dual-stack networking

Version(s):
4.20+

Issue:
https://issues.redhat.com/browse/TELCODOCS-2529

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@slovern slovern merged commit 3778eb3 into openshift:main Nov 4, 2025
2 checks passed
@slovern
Copy link
Contributor

slovern commented Nov 4, 2025

/cherrypick enterprise-4.21

@slovern
Copy link
Contributor

slovern commented Nov 4, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@slovern: new pull request created: #101717

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@slovern: new pull request created: #101719

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants