Skip to content

Conversation

@prithvipatil97
Copy link
Contributor

@prithvipatil97 prithvipatil97 commented Oct 29, 2025

Here is the current look:

  • Create an object storage secret with the name logging-loki-minio by running the following command:
$ oc create secret generic logging-loki-minio \  1 
  --from-literal=bucketnames="<bucket_name>" \
  --from-literal=endpoint="<minio_bucket_endpoint>" \
  --from-literal=access_key_id="<minio_access_key_id>" \
  --from-literal=access_key_secret="<minio_access_key_secret>"
  --from-literal=forcepathstyle="true"
  • The backslash () is missing from line no. 5
  • As backslash is a line continuation character, so we need to add it to the command.
  • So it will complete the command.

Here is the updated look:

  • Create an object storage secret with the name logging-loki-minio by running the following command:
$ oc create secret generic logging-loki-minio \  1 
  --from-literal=bucketnames="<bucket_name>" \
  --from-literal=endpoint="<minio_bucket_endpoint>" \
  --from-literal=access_key_id="<minio_access_key_id>" \
  --from-literal=access_key_secret="<minio_access_key_secret>" \
  --from-literal=forcepathstyle="true"

Version(s):

Logging 6.4, Logging 6.3, Logging 6.2, Logging 6.1, Logging 6.0

Issue:

https://issues.redhat.com/browse/OBSDOCS-2681

Link to docs preview:

https://101355--ocpdocs-pr.netlify.app/
https://101355--ocpdocs-pr.netlify.app/openshift-logging/latest/configuring/configuring-the-log-store.html

QE review:

  • QE has approved this change.

Additional information:

Line continuation character () is missing from the Minio Storage Secret command
Here is the documentation link:
https://docs.redhat.com/en/documentation/red_hat_openshift_logging/6.3/html/configuring_logging/configuring-lokistack-storage#logging-loki-storage-minio_configuring-the-log-store 
The backslash () must be set at the end of a line, as it is a line continuation character.
Here is the current look:

Create an object storage secret with the name logging-loki-minio by running the following command:
$ oc create secret generic logging-loki-minio \  1 
  --from-literal=bucketnames="<bucket_name>" \
  --from-literal=endpoint="<minio_bucket_endpoint>" \
  --from-literal=access_key_id="<minio_access_key_id>" \
  --from-literal=access_key_secret="<minio_access_key_secret>"
  --from-literal=forcepathstyle="true"
The backslash ()  is missing from line no. 5
As backslash is a line continuation character,  so we need to add it to the command.
So it will complete the command.
Here is the updated look:

Create an object storage secret with the name logging-loki-minio by running the following command:
$ oc create secret generic logging-loki-minio \  1 
  --from-literal=bucketnames="<bucket_name>" \
  --from-literal=endpoint="<minio_bucket_endpoint>" \
  --from-literal=access_key_id="<minio_access_key_id>" \
  --from-literal=access_key_secret="<minio_access_key_secret>" \
  --from-literal=forcepathstyle="true"
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2025
@ocpdocs-previewbot
Copy link

@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

@prithvipatil97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prithvipatil97
Copy link
Contributor Author

Hello Team,
I need QE approval for this change.

All checks have passed, and I have reviewed the PR with the peer review checklist.

@anpingli , @QiaolingTang , it would be really helpful if someone could please take a look and provide QE approval for this change.

Thanks in advance.

Regards,
Prithviraj Patil

@QiaolingTang
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@prithvipatil97
Copy link
Contributor Author

Hello QiaolingTang,
Thank you very much for providing the QE approval for this change.

Regards,
Prithviraj Patil

@prithvipatil97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Oct 30, 2025
@briandooley briandooley merged commit 511bf46 into openshift:standalone-logging-docs-main Nov 10, 2025
2 checks passed
@briandooley
Copy link
Contributor

/cherrypick standalone-logging-docs-6.0

@briandooley
Copy link
Contributor

/cherrypick standalone-logging-docs-6.1

@briandooley
Copy link
Contributor

/cherrypick standalone-logging-docs-6.2

@briandooley
Copy link
Contributor

/cherrypick standalone-logging-docs-6.3

@briandooley
Copy link
Contributor

/cherrypick standalone-logging-docs-6.4

@openshift-cherrypick-robot

@briandooley: #101355 failed to apply on top of branch "standalone-logging-docs-6.0":

Applying: Update documentation for logging-loki-minio secret
Using index info to reconstruct a base tree...
M	modules/logging-loki-storage-minio.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/logging-loki-storage-minio.adoc
CONFLICT (content): Merge conflict in modules/logging-loki-storage-minio.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update documentation for logging-loki-minio secret

In response to this:

/cherrypick standalone-logging-docs-6.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@briandooley: #101355 failed to apply on top of branch "standalone-logging-docs-6.1":

Applying: Update documentation for logging-loki-minio secret
Using index info to reconstruct a base tree...
M	modules/logging-loki-storage-minio.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/logging-loki-storage-minio.adoc
CONFLICT (content): Merge conflict in modules/logging-loki-storage-minio.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update documentation for logging-loki-minio secret

In response to this:

/cherrypick standalone-logging-docs-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@briandooley: #101355 failed to apply on top of branch "standalone-logging-docs-6.2":

Applying: Update documentation for logging-loki-minio secret
Using index info to reconstruct a base tree...
M	modules/logging-loki-storage-minio.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/logging-loki-storage-minio.adoc
CONFLICT (content): Merge conflict in modules/logging-loki-storage-minio.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update documentation for logging-loki-minio secret

In response to this:

/cherrypick standalone-logging-docs-6.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@briandooley: new pull request created: #102114

In response to this:

/cherrypick standalone-logging-docs-6.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@briandooley: new pull request created: #102115

In response to this:

/cherrypick standalone-logging-docs-6.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. merge-review-needed Signifies that the merge review team needs to review this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants