OSDOCS-16538:Life Cycle Extension -UI for OSD and ROSA. #101435
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@AedinC: This pull request references OSDOCS-16538 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
@AedinC: This pull request references OSDOCS-16538 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
modules/osd-create-cluster-ccs.adoc
Outdated
| + | ||
| [NOTE] | ||
| ==== | ||
| Channel group options include *Stable* (default option) and *EUS*. For more information about the Stable and EUS channel group options, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.19/html/updating_clusters/understanding-openshift-updates-1#understanding-update-channels-releases[Understanding update channels and releases]. |
There was a problem hiding this comment.
are we ok with linking 4.19 docs here vs 4.20 or latest? Just to ensure we align with what we usually to do
There was a problem hiding this comment.
Missed that - will update now!
|
lgtm |
|
@AedinC Both the preview links focus on cluster creation. How about day-2 operation for changing the channel group in the UI for an existing cluster? |
|
@AedinC: This pull request references OSDOCS-16538 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
modules/create-wif-cluster-ocm.adoc
Outdated
| + | ||
| [NOTE] | ||
| ==== | ||
| Channel group options include *Stable* (default option) and *EUS*. For more information about the Stable and EUS channel group options, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/updating_clusters/understanding-openshift-updates-1#understanding-update-channels-releases[Understanding update channels and releases]. |
There was a problem hiding this comment.
For the link URL, I would use latest instead of the actual version number. This will automatically redirect to the latest version (which is 4.20). That way you don't have to update this link every time a new version of OpenShift is released.
A couple optional suggestions:
- For the link text, specify that the link goes to the OCP documentation since we're sending the reader to a different doc set.
- Consider using a snippet for this note since it's repeated in a few different places.
| Channel group options include *Stable* (default option) and *EUS*. For more information about the Stable and EUS channel group options, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html/updating_clusters/understanding-openshift-updates-1#understanding-update-channels-releases[Understanding update channels and releases]. | |
| Channel group options include *Stable* (default option) and *EUS*. For more information about the Stable and EUS channel group options, see link:https://docs.redhat.com/en/documentation/openshift_container_platform/latest/html/updating_clusters/understanding-openshift-updates-1#understanding-update-channels-releases[Understanding update channels and releases] in the OpenShift Container Platform documentation. |
bhardesty
left a comment
bhardesty
left a comment
There was a problem hiding this comment.
Looks good! I just had a couple small suggestions.
Thanks @bhardesty! |
|
@AedinC: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@AedinC: This pull request references OSDOCS-16538 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick enterprise-4.20 |
|
@EricPonvelle: new pull request created: #101517 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@EricPonvelle: new pull request created: #101518 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8 participants
Version(s):
4.20+
Issue:
https://issues.redhat.com/browse/OSDOCS-16538
Link to docs preview:
Peer review:
SME review:
QE review:
Additional information: