Skip to content

Conversation

@navaneethas
Copy link
Contributor

@navaneethas navaneethas commented Nov 3, 2025

Hi Team,

Issue:

The oc command prefix is missing in the pod resizing examples in the following OpenShift 4.20 documentation: https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html-single/nodes/index#nodes-pods-adjust-resources-in-place-about_nodes-pods-adjust-resources-in-place

Current Example commands:

$ oc edit pod <pod_name>  --subresource resize

$ apply -f <file_name>.yaml --subresource resize

$ patch pod <pod_name> --subresource resize --patch \
  '{"spec":{"containers":[{"name":"pause", "resources":{"requests":{"cpu":"800m"}, "limits":{"cpu":"800m"}}}]}}'

Expected Example commands:

$ oc edit pod <pod_name>  --subresource resize

$ oc apply -f <file_name>.yaml --subresource resize

$ oc patch pod <pod_name> --subresource resize --patch \
  '{"spec":{"containers":[{"name":"pause", "resources":{"requests":{"cpu":"800m"}, "limits":{"cpu":"800m"}}}]}}'  

Version(s):
4.20

Issue:

https://issues.redhat.com/browse/OCPBUGS-64573

Link to docs preview:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html-single/nodes/index#nodes-pods-adjust-resources-in-place-about_nodes-pods-adjust-resources-in-place

QE review:

Additional information:

Hi Team,


The oc command prefix is missing in the pod resizing examples in the following OpenShift 4.20 documentation: https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html-single/nodes/index#nodes-pods-adjust-resources-in-place-about_nodes-pods-adjust-resources-in-place


Current Example commands:

~~~
$ oc edit pod <pod_name>  --subresource resize

$ apply -f <file_name>.yaml --subresource resize

$ patch pod <pod_name> --subresource resize --patch \
  '{"spec":{"containers":[{"name":"pause", "resources":{"requests":{"cpu":"800m"}, "limits":{"cpu":"800m"}}}]}}'
~~~


Expected Example commands:

~~~
$ oc edit pod <pod_name>  --subresource resize

$ oc apply -f <file_name>.yaml --subresource resize

$ oc patch pod <pod_name> --subresource resize --patch \
  '{"spec":{"containers":[{"name":"pause", "resources":{"requests":{"cpu":"800m"}, "limits":{"cpu":"800m"}}}]}}'  
~~~

I have created the following documentation bug as well:

 https://issues.redhat.com/browse/OCPBUGS-64573
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

Hi @navaneethas. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@navaneethas
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

@navaneethas: The label(s) /label peer-review-needed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, ok-to-test, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@navaneethas
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2025

@navaneethas: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@navaneethas
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

@navaneethas: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@navaneethas
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

@navaneethas: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@navaneethas
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

@navaneethas: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat]

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michaelryanpeter
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 5, 2025
@ShaunaDiaz
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2025
@ocpdocs-previewbot
Copy link

@openshift-ci
Copy link

openshift-ci bot commented Nov 6, 2025

@navaneethas: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ShaunaDiaz
Copy link
Contributor

@navaneethas We need a QE or SME ack. Working on that for you.

@ShaunaDiaz ShaunaDiaz added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.20 branch/enterprise-4.21 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 6, 2025
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Nov 6, 2025
@ShaunaDiaz ShaunaDiaz added ok-to-merge and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Nov 6, 2025
@ShaunaDiaz ShaunaDiaz merged commit 75d7903 into openshift:main Nov 6, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.21

@ShaunaDiaz
Copy link
Contributor

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #101904

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@ShaunaDiaz: new pull request created: #101905

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mburke5678
Copy link
Contributor

@ShaunaDiaz Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 ok-to-merge ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants