-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update nodes-pods-adjust-resources-in-place-about.adoc #101568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi Team, The oc command prefix is missing in the pod resizing examples in the following OpenShift 4.20 documentation: https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html-single/nodes/index#nodes-pods-adjust-resources-in-place-about_nodes-pods-adjust-resources-in-place Current Example commands: ~~~ $ oc edit pod <pod_name> --subresource resize $ apply -f <file_name>.yaml --subresource resize $ patch pod <pod_name> --subresource resize --patch \ '{"spec":{"containers":[{"name":"pause", "resources":{"requests":{"cpu":"800m"}, "limits":{"cpu":"800m"}}}]}}' ~~~ Expected Example commands: ~~~ $ oc edit pod <pod_name> --subresource resize $ oc apply -f <file_name>.yaml --subresource resize $ oc patch pod <pod_name> --subresource resize --patch \ '{"spec":{"containers":[{"name":"pause", "resources":{"requests":{"cpu":"800m"}, "limits":{"cpu":"800m"}}}]}}' ~~~ I have created the following documentation bug as well: https://issues.redhat.com/browse/OCPBUGS-64573
|
Hi @navaneethas. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label peer-review-needed |
|
@navaneethas: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label merge-review-needed |
|
@navaneethas: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label merge-review-needed |
|
@navaneethas: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label merge-review-needed |
|
@navaneethas: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label merge-review-needed |
|
@navaneethas: Can not set label merge-review-needed: Must be member in one of these teams: [team-red-hat] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label merge-review-needed |
|
/ok-to-test |
|
🤖 Thu Nov 06 13:17:51 - Prow CI generated the docs preview: |
|
@navaneethas: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@navaneethas We need a QE or SME ack. Working on that for you. |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
@ShaunaDiaz: new pull request created: #101904 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #101905 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz Thank you!! |
Hi Team,
Issue:
The oc command prefix is missing in the pod resizing examples in the following OpenShift 4.20 documentation: https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html-single/nodes/index#nodes-pods-adjust-resources-in-place-about_nodes-pods-adjust-resources-in-place
Current Example commands:
Expected Example commands:
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/OCPBUGS-64573
Link to docs preview:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.20/html-single/nodes/index#nodes-pods-adjust-resources-in-place-about_nodes-pods-adjust-resources-in-place
QE review:
Additional information: