-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-17145:Life Cycle (Extension) (UI for OSD and ROSA) Day 2. #101576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@AedinC: This pull request references OSDOCS-17145 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@AedinC: This pull request references OSDOCS-17145 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@AedinC: This pull request references OSDOCS-17145 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@andreadecorte Can you please review this? Many thanks. |
|
1 small suggestion, LGTM, thanks |
modules/ocm-overview-tab.adoc
Outdated
| * **Availability** shows multizone for {rosa-short} clusters. | ||
| endif::openshift-rosa-hcp[] | ||
| ifndef::openshift-enterprise[] | ||
| * **Channel group** shows the update channel for the cluster, such as stable,fast, or eus. Support for channel groups varies by cluster version. If support channel editing is available, this field can be changed by clicking the pencil icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we mention only stable and eus https://docs.redhat.com/en/documentation/red_hat_openshift_service_on_aws/4/html/cli_tools/rosa-cli, I don't know if we want to align the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andreadecorte. I missed that Mark had dropped 'fast' from the CLI PR updates. I will update this accordingly.
|
lgtm |
|
@AedinC: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.20 |
|
@EricPonvelle: new pull request created: #101613 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@EricPonvelle: new pull request created: #101614 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.20+
Issue:
https://issues.redhat.com/browse/OSDOCS-17145
Link to docs preview:
QE review:
Additional information: