Skip to content

OCPBUGS#64614 Formatting changes in updating a cluster by using the cli #101638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2025
Merged

OCPBUGS#64614 Formatting changes in updating a cluster by using the cli #101638

merged 1 commit into from
Nov 10, 2025

Conversation

@cbippley
Copy link
Contributor

@cbippley cbippley commented Nov 3, 2025 •
edited
Loading

Version(s): 4.20+

Issue: OCPBUGS-64614

Link to docs preview: https://101638--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/updating_a_cluster/updating-cluster-cli.html#update-upgrading-cli_updating-cluster-cli

QE review: NA, no content changes. Only formatting.

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 3, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 3, 2025 •
edited
Loading

🤖 Wed Nov 05 21:00:22 - Prow CI generated the docs preview:

https://101638--ocpdocs-pr.netlify.app/openshift-enterprise/latest/updating/updating_a_cluster/updating-cluster-cli.html

wking
wking reviewed Nov 3, 2025
View reviewed changes
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2025
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2025
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 4, 2025
@cbippley
Copy link
Contributor Author

cbippley commented Nov 4, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 4, 2025
wking
wking approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2025
bergerhoffer
bergerhoffer reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least one thing to fix before merging

@bergerhoffer bergerhoffer added branch/enterprise-4.20 branch/enterprise-4.21 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 5, 2025
@bergerhoffer bergerhoffer added this to the Continuous Release milestone Nov 5, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

New changes are detected. LGTM label has been removed.

@cbippley
Copy link
Contributor Author

cbippley commented Nov 5, 2025

@bergerhoffer Changes made, thank you!

@openshift-ci
Copy link

openshift-ci bot commented Nov 5, 2025

@cbippley: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bergerhoffer
bergerhoffer reviewed Nov 10, 2025
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM!

@bergerhoffer bergerhoffer merged commit 2c6784c into openshift:main Nov 10, 2025
2 checks passed
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Nov 10, 2025

/cherrypick enterprise-4.21

@bergerhoffer
Copy link
Contributor

bergerhoffer commented Nov 10, 2025

/cherrypick enterprise-4.20

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 10, 2025

@bergerhoffer: new pull request created: #102158

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 10, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 10, 2025

@bergerhoffer: new pull request created: #102159

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 10, 2025
Merged
@cbippley cbippley deleted the OCPBUGS-64614 branch November 10, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

+1 more reviewer

@wking wking wking approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

branch/enterprise-4.20 branch/enterprise-4.21 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

5 participants

@cbippley @ocpdocs-previewbot @bergerhoffer @openshift-cherrypick-robot @wking