-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS 17238 Update MCO to reflect API changes made for Status Reporting #102021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b4c89b1 to
de8ee3c
Compare
|
@isabella-janssen Can you PTAL? |
isabella-janssen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @mburke5678!
|
@sergiordlr PTAL |
|
@ptalgulk01 Can you PTAL? |
|
New changes are detected. LGTM label has been removed. |
eee733e to
9a2b983
Compare
|
Hello @isabella-janssen , do we need to specify that to see the OCL images status update in MCN too, we need to have TechPreview |
|
Hi @ptalgulk01, good catch. The TP warning does not seem to note that the config image values are also only TP. Would you be able to include that, @mburke5678?
|
|
@ptalgulk01 @isabella-janssen I added the requirement to enable TP feature gates in commit e5509e1. Thank you!! |
|
looks good, Thankyou for taking a look! |
JoeAldinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions, wasn't sure about CQA stuff in new PRs like this but I noted them just in case.
e5509e1 to
5f17956
Compare
5f17956 to
940f503
Compare
|
@mburke5678: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.21 |
|
@mburke5678: new pull request created: #103068 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |

https://issues.redhat.com/browse/OSDOCS-17238
Link to docs preview:
Machine creation overview -> About checking machine config node status -- Added
ImagePulledFromRegistrycondition with TP snippet, Example machine config node output and preceding paragraph with TP snippet, and Additional Resource links.Image mode for OpenShift -> Using the on-cluster image mode to apply a custom layered image -- Added verification step 4 with TP snippet, and Additional Resource link to the Feature Gate assembly.
QE review: