OSDOCS#15340:OSDOCS#15339: Cluster autoscaler features in HCP #102493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
size/L
|
🤖 Tue Nov 18 09:14:34 - Prow CI generated the docs preview: |
xenolinux
force-pushed
the
hcp-autoscaling
branch
2 times, most recently
from
4db6c67 to
c090a52
Compare
gaol
suggested changes
Nov 14, 2025
gaol
left a comment
gaol
left a comment
There was a problem hiding this comment.
I have some minor comments, would you please check ?
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
c090a52 to
5394361
Compare
xenolinux
added
the
do-not-merge/hold
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
5394361 to
c82a43a
Compare
gaol
reviewed
Nov 14, 2025
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
c82a43a to
421a1d5
Compare
|
/lgtm |
Contributor
Author
|
/test validate-asciidoc |
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
421a1d5 to
4a94660
Compare
|
New changes are detected. LGTM label has been removed. |
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
4a94660 to
e96e4b6
Compare
xenolinux
added
the
merge-review-needed
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
e96e4b6 to
0445970
Compare
dfitzmau
added
merge-review-in-progress
dfitzmau
reviewed
Nov 17, 2025
Contributor
|
Hi, @xenolinux . Nice work. Feel free to merge this PR when the certain commented items are addressed. Thanks! |
dfitzmau
removed
the
merge-review-in-progress
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
0445970 to
1f58a04
Compare
Contributor
Author
Ack. Thanks for the review. |
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
1f58a04 to
49e5c2f
Compare
xenolinux
force-pushed
the
hcp-autoscaling
branch
from
49e5c2f to
8c9d818
Compare
|
@xenolinux: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version(s): 4.20+
Issue:
Link to docs preview:
QE review:
Additional information:
This PR should not be merged until HCP for OCP 4.20 is GA (tentative GA date: Dec 3)