-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSM-11361 [DOCS] http route for waypoint not working and waypoint authorization not enforced #102591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-11361 [DOCS] http route for waypoint not working and waypoint authorization not enforced #102591
Conversation
|
/label service-mesh |
|
🤖 Tue Nov 18 10:48:58 - Prow CI generated the docs preview: https://102591--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/gateways/ossm-getting-traffic-into-a-mesh.html |
sridhargaddam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @shreyasiddhartha
kaldesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Peer review is complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small comment about broken numbering before merging, thank you!
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Show resolved
Hide resolved
modules/ossm-exposing-a-service-by-using-the-kubernetes-gateway-api-in-ambient-mode.adoc
Show resolved
Hide resolved
c2b759f to
84adfbb
Compare
|
@shreyasiddhartha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
LGTM, merging |
82781ab
into
openshift:service-mesh-docs-main
|
/cherrypick service-mesh-docs-3.2 |
|
@eromanova97: new pull request created: #102664 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Change type: Doc update; Docs: http route for waypoint not working and waypoint authorization not enforced
Doc JIRA: https://issues.redhat.com/browse/OSSM-11361
Fix Version: service-mesh-docs-main and service-mesh-docs-3.2
Doc Preview:
SME Review/QE Review: @sridhargaddam @FilipB
Peer Review: @kaldesai