Skip to content

Conversation

@shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Nov 25, 2025

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 25, 2025

@shreyasiddhartha
Copy link
Contributor Author

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label Nov 25, 2025
@shreyasiddhartha shreyasiddhartha changed the title OSSM-11010 [DOCS] Update OSSM metrics docs for ambient mode OSSM-11009 [DOCS] Update OSSM metrics docs for ambient mode Nov 25, 2025
====
You can enable user-workload monitoring by applying the `ConfigMap` change for metrics integration. For more information, see link:https://docs.openshift.com/container-platform/latest/observability/monitoring/enabling-monitoring-for-user-defined-projects.html[Enabling monitoring for user-defined projects].
====
* You have deployed the Bookinfo application in ambient mode to use the following example. For more information, see https://docs.redhat.com/en/documentation/red_hat_openshift_service_mesh/3.2/html/installing/ossm-istio-ambient-mode#ossm-deploying-bookinfo-application-istio-ambient-mode_ossm-istio-ambient-mode[Deploying the Bookinfo application in Istio ambient mode].
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the step of deploying a Bookinfo application is a Prerequisite.
We can move this Bookinfo step from Prerequisties section to a Validation section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added it as a prereq in the verifying scetion for metrics. Since, I see there is s step there to see the Bookinfo productpage service. If you think it is still not required, I can remove it.

.Prerequisites

* You have installed the {SMProductName} Operator.
* You have enabled the user-workload monitoring.
Copy link

@yxun yxun Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we mention "the ConfigMap change" below, it's better to give an example and that's all user need to configure.

Suggested change
* You have enabled the user-workload monitoring.
* You have enabled the user-workload monitoring, similar to the following example:
[source,yaml]
----
apiVersion: v1
kind: ConfigMap
metadata:
name: cluster-monitoring-config
namespace: openshift-monitoring
data:
config.yaml: |
enableUserWorkload: true
----

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will break the parallelism, if I insert an example in prerqs (which I don't think we have done in docs before). The link below already points the user to Configuring user workload monitoring. So, currently I will skip inserting this.

* You have installed the {SMProductName} Operator.
* User-workload monitoring is enabled. See link:https://docs.openshift.com/container-platform/4.16/observability/monitoring/enabling-monitoring-for-user-defined-projects.html[Enabling monitoring for user-defined projects].
* You have enabled the user-workload monitoring.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* You have enabled the user-workload monitoring.
* You have enabled the user-workload monitoring, similar to the following example:
[source,yaml]
----
apiVersion: v1
kind: ConfigMap
metadata:
name: cluster-monitoring-config
namespace: openshift-monitoring
data:
config.yaml: |
enableUserWorkload: true
----

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above: It will break the parallelism, if I insert an example in prerqs (which I don't think we have done in docs before). The link below already points the user to Configuring user workload monitoring. So, currently I will skip inserting this.

----

. Create a YAML file named `podmonitor.yml` to collect metrics from the {istio} proxies:
. Create a YAML file named `podmonitor.yml` to collect metrics from the {istio} proxies similar to the following example:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PodMonitor step section is not working with OSSM in recent OpenShift platform versions. We may remove this PodMonitor Procedure part from our doc. We will introduce an easy way of integrating this in the incoming 3.3 release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the PodMonitor step.

@openshift-ci
Copy link

openshift-ci bot commented Nov 27, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants