Skip to content

Conversation

@shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Nov 25, 2025

Change type: Doc update; Update OSSM tracing docs for ambient mode

Doc JIRA: https://issues.redhat.com/browse/OSSM-11010

Fix Version: service-mesh-docs-main and service-mesh-docs-3.2

Doc Preview: https://102984--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/observability/traces/ossm-distr-tracing.html

SME Review/QE Review:
Peer Review:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2025
@ocpdocs-previewbot
Copy link

🤖 Tue Nov 25 10:55:52 - Prow CI generated the docs preview:

https://102984--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/observability/traces/ossm-distr-tracing.html

@shreyasiddhartha
Copy link
Contributor Author

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label Nov 25, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 25, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@yxun yxun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request additional change to the existing sidecar mode tracing doc.


. Create an Istio Telemetry resource to enable tracers defined in `spec.values.meshConfig.ExtensionProviders`:
. Create an Istio Telemetry resource to enable tracers defined in `spec.values.meshConfig.ExtensionProviders`, similar to the following example:
+
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Around line 97. We need to add a note about

. Optional: Use a single {istio} Telemetry resource for both a Prometheus metrics provider and a tracing provider by setting spec.metrics.overrides.disabled field to false. This enables the Prometheus metrics provider. You do not need this step if you have configured metrics through the OpenShift Cluster Monitoring approach described above.

That was requested for our sidecar mode tracing doc change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants