-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSM-11010 [DOCS] Update OSSM tracing docs for ambient mode #102984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: service-mesh-docs-main
Are you sure you want to change the base?
OSSM-11010 [DOCS] Update OSSM tracing docs for ambient mode #102984
Conversation
|
🤖 Tue Nov 25 10:55:52 - Prow CI generated the docs preview: |
|
/label service-mesh |
|
@shreyasiddhartha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
yxun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request additional change to the existing sidecar mode tracing doc.
|
|
||
| . Create an Istio Telemetry resource to enable tracers defined in `spec.values.meshConfig.ExtensionProviders`: | ||
| . Create an Istio Telemetry resource to enable tracers defined in `spec.values.meshConfig.ExtensionProviders`, similar to the following example: | ||
| + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Around line 97. We need to add a note about
. Optional: Use a single {istio} Telemetry resource for both a Prometheus metrics provider and a tracing provider by setting spec.metrics.overrides.disabled field to false. This enables the Prometheus metrics provider. You do not need this step if you have configured metrics through the OpenShift Cluster Monitoring approach described above.
That was requested for our sidecar mode tracing doc change as well.
Change type: Doc update; Update OSSM tracing docs for ambient mode
Doc JIRA: https://issues.redhat.com/browse/OSSM-11010
Fix Version: service-mesh-docs-main and service-mesh-docs-3.2
Doc Preview: https://102984--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/observability/traces/ossm-distr-tracing.html
SME Review/QE Review:
Peer Review: