Skip to content

Document router behavior changes due to rhbz#1584701 #12025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2018
Merged

Document router behavior changes due to rhbz#1584701 #12025

merged 1 commit into from
Sep 20, 2018

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Sep 13, 2018

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2018
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Sep 13, 2018

The preview will be availble shortly at:

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2018
@mburke5678
Copy link
Contributor Author

mburke5678 commented Sep 13, 2018 •
edited
Loading

@knobunc PTAL. Change to docs for new oc set route-backend behavior from https://bugzilla.redhat.com/show_bug.cgi?id=1628615

@fcami
Copy link

fcami commented Sep 13, 2018 •
edited
Loading

@mburke5678 maybe:

  • "does accept persistent connections." => "does continue to serve existing persistent connections."
  • please align (some lines seem too long)

but otherwise lgtm.

@mburke5678
Copy link
Contributor Author

mburke5678 commented Sep 13, 2018

@anpingli PTAL

@mburke5678
Copy link
Contributor Author

mburke5678 commented Sep 20, 2018

@zhaozhanqi approved in BZ.

@mburke5678
Copy link
Contributor Author

mburke5678 commented Sep 20, 2018

@openshift/team-documentation Small change. PTAL

kalexand-rh
kalexand-rh reviewed Sep 20, 2018
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😸

@kalexand-rh kalexand-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 20, 2018
@mburke5678 mburke5678 merged commit 5af1cb1 into openshift:master Sep 20, 2018
@mburke5678
Copy link
Contributor Author

mburke5678 commented Sep 20, 2018

/cherrypick enterprise-3.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 20, 2018
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 20, 2018

@mburke5678: new pull request created: #12140

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678 mburke5678 deleted the BZ-1628615 branch September 20, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

Assignees

No one assigned

Labels

branch/enterprise-3.11 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mburke5678 @openshift-docs-preview-bot @fcami @openshift-cherrypick-robot @kalexand-rh @openshift-ci-robot