Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

https://bugzilla.redhat.com/show_bug.cgi?id=1639080

@ericavonb, how does this sound?

@jianlinliu, will you PTAL?

This bug was filed against 3.10 - do you know how far back this change is true?

@kalexand-rh kalexand-rh added this to the Next Release milestone Oct 24, 2018
@kalexand-rh kalexand-rh self-assigned this Oct 24, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2018
@openshift-docs-preview-bot

The preview will be availble shortly at:

@ericavonb
Copy link

@kalexand-rh lgtm!

@kalexand-rh
Copy link
Contributor Author

@stuartchuan, PTAL?

@stuartchuan
Copy link

As I understand, when set the insecure: true and the url scheme is ldap, loading the config should ignore the ca no matter what's setting for the ca field.

@kalexand-rh
Copy link
Contributor Author

@stuartchuan, the bug says that it's taking effect anyway.

@kalexand-rh
Copy link
Contributor Author

@stuartchuan, will you PTAL?

@stuartchuan
Copy link

I still think this is not the root cause fix, just a workaround. I think the bug should be fixed in code but not doc.
@ericavonb what do you think?

@kalexand-rh
Copy link
Contributor Author

@ericavonb, when you have a minute, will you PTAL?

@ericavonb
Copy link

@kalexand-rh @stuartchuan I think this is the correct behavior (with the docs here) in accord with the standards around ldap urls and tls.

@kalexand-rh
Copy link
Contributor Author

Thanks @ericavonb. @stuartchuan, if this is correct, can I merge this to 3.10 and 3.11?

@stuartchuan
Copy link

@kalexand-rh it's OK to merge.

@kalexand-rh
Copy link
Contributor Author

Thanks! Merging.

@kalexand-rh kalexand-rh merged commit 30c3e2a into openshift:master Nov 30, 2018
@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-3.11

@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-3.10

@kalexand-rh kalexand-rh deleted the BZ1639080 branch November 30, 2018 13:18
@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #12995

In response to this:

/cherrypick enterprise-3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #12996

In response to this:

/cherrypick enterprise-3.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-3.10 branch/enterprise-3.11 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants