-
Notifications
You must be signed in to change notification settings - Fork 1.8k
bug 1639080 clarifying insecure connection override #12631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be availble shortly at:
|
|
@kalexand-rh lgtm! |
|
@stuartchuan, PTAL? |
|
As I understand, when set the |
|
@stuartchuan, the bug says that it's taking effect anyway. |
|
@stuartchuan, will you PTAL? |
|
I still think this is not the root cause fix, just a workaround. I think the bug should be fixed in code but not doc. |
|
@ericavonb, when you have a minute, will you PTAL? |
|
@kalexand-rh @stuartchuan I think this is the correct behavior (with the docs here) in accord with the standards around ldap urls and tls. |
|
Thanks @ericavonb. @stuartchuan, if this is correct, can I merge this to 3.10 and 3.11? |
|
@kalexand-rh it's OK to merge. |
|
Thanks! Merging. |
|
/cherrypick enterprise-3.11 |
|
/cherrypick enterprise-3.10 |
|
@kalexand-rh: new pull request created: #12995 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kalexand-rh: new pull request created: #12996 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
https://bugzilla.redhat.com/show_bug.cgi?id=1639080
@ericavonb, how does this sound?
@jianlinliu, will you PTAL?
This bug was filed against 3.10 - do you know how far back this change is true?