-
Couldn't load subscription status.
- Fork 1.8k
Fix logging documentation for eventrouter #17052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
|
@richm Do all the instances of |
|
@xltian Can you please assign this PR for review? Thank you! |
|
@anpingli will review. |
|
LGTM |
|
@richm PTAL |
|
The convention for 4.x is to remove the "logging-" prefix from names of objects in the cluster like pods, deployments, secrets, configmaps, etc. I have submitted a PR for logging to fix this: https://github.com/openshift/origin-aggregated-logging/pull/1766/files#diff-6bd9f2ef704c789f35e1652b8d6d5449 Note that image names will still have a "logging-" or "origin-logging-" or "ose-logging-" prefix. |
|
@richm Thanks. I replaced the template in the docs with the one from your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
New changes are detected. LGTM label has been removed. |
|
/cherrypick enterprise-4.2 |
|
@mburke5678: new pull request created: #17111 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.1 |
|
@mburke5678: new pull request created: #17112 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Item #2 in https://bugzilla.redhat.com/show_bug.cgi?id=1758222#c0