Remove ExperimentalCriticalPodAnnotation from featureflags #18044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Contributor
Author
|
@rphillips PTAL |
|
The preview will be available shortly at: |
Contributor
Author
|
@rphillips PTAL |
Contributor
Author
|
@jhou1 You have reviewed the feature gates topic for me in the past. Is this an issue you can review? Removing |
Contributor
Author
|
@rphillips PTAL |
Contributor
Author
|
@jhou1 @rphillips Please take a look at this small change. |
Member
|
Not an area I'm familiar with, but with openshift/api#515 this looks good. |
Contributor
|
LGTM. CC @zhouying7780 |
Contributor
Author
|
/cherrypick enterprise-4.3 |
mburke5678
deleted the
nodes-Remove-ExperimentalCriticalPodAnnotation
branch
|
@mburke5678: new pull request created: #18758 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openshift/api#515