Skip to content

Conversation

@maxwelldb
Copy link
Contributor

Commit addresses BZ 1790298.
@maxwelldb maxwelldb added this to the Next Release milestone Jan 14, 2020
@maxwelldb maxwelldb self-assigned this Jan 14, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2020
@maxwelldb maxwelldb changed the title Add ShiftStack install externalDNS property. Add ShiftStack install externalDNS property - BZ 1790298 Jan 14, 2020
@morenod
Copy link

morenod commented Jan 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@morenod morenod removed their assignment Jan 16, 2020
@maxwelldb maxwelldb removed the request for review from tomassedovic January 16, 2020 17:24
@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 16, 2020
@ahardin-rh
Copy link
Contributor

LGTM!

@maxwelldb maxwelldb merged commit 3b5bafc into openshift:master Jan 16, 2020
@maxwelldb
Copy link
Contributor Author

/cherrypick enterprise-4.2

@maxwelldb maxwelldb deleted the shiftstack-external-dns-custom branch January 16, 2020 17:40
@maxwelldb
Copy link
Contributor Author

/cherrypick enterprise-4.3

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #19095

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@maxwelldb: new pull request created: #19096

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.2 branch/enterprise-4.3 branch/enterprise-4.4 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants