Skip to content

Routing #19867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

Routing #19867

merged 1 commit into from
May 8, 2020

Conversation

neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented Feb 20, 2020 •
edited
Loading

I’m happiest with the routing module and the assembly right now. The ingress and egress module need work, but I have a plan. When I get done the organization of the topics may change.

OSSMDOC-15
OSSMDOC-27
OSSMDOC-28
OSSMDOC-30

This should be cherrypicked to the 4.3, 4.4, and 4.5 branch.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 20, 2020
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@neal-timpe neal-timpe force-pushed the routing branch 3 times, most recently from a922bee to d5b218d Compare March 3, 2020 15:54
tvieira
tvieira reviewed Mar 3, 2020
View reviewed changes
Copy link

@tvieira tvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swap kubectl with oc commands.

jwendell
jwendell reviewed Mar 10, 2020
View reviewed changes
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 11, 2020
@neal-timpe neal-timpe changed the title [WIP] Routing Routing Mar 16, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2020
@neal-timpe neal-timpe requested review from jwendell and tvieira March 24, 2020 11:59
jwendell
jwendell suggested changes Mar 24, 2020
View reviewed changes
@neal-timpe neal-timpe requested a review from jwendell March 30, 2020 20:49
@tvieira
Copy link

tvieira commented Apr 1, 2020

LGTM

@neal-timpe neal-timpe requested a review from JStickler April 1, 2020 16:15
@neal-timpe neal-timpe force-pushed the routing branch 2 times, most recently from 63981ce to fe0a6ac Compare May 4, 2020 19:46
JStickler
JStickler reviewed May 8, 2020
View reviewed changes
JStickler
JStickler reviewed May 8, 2020
View reviewed changes
JStickler
JStickler reviewed May 8, 2020
View reviewed changes
JStickler
JStickler reviewed May 8, 2020
View reviewed changes
JStickler
JStickler reviewed May 8, 2020
View reviewed changes
JStickler
JStickler reviewed May 8, 2020
View reviewed changes
JStickler
JStickler reviewed May 8, 2020
View reviewed changes
JStickler
JStickler approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JStickler JStickler merged commit d9b50df into openshift:master May 8, 2020
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 8, 2020
Merged
@openshift-cherrypick-robot
Copy link

@JStickler: new pull request created: #21975

In response to this:

/cherry-pick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot
Copy link

@JStickler: new pull request created: #21976

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 8, 2020
Merged
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 8, 2020
Merged
@openshift-cherrypick-robot
Copy link

@JStickler: new pull request created: #21977

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe deleted the routing branch May 12, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@jwendell jwendell jwendell approved these changes

@tvieira tvieira tvieira approved these changes

@JStickler JStickler JStickler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@neal-timpe @openshift-docs-preview-bot @tvieira @JStickler @openshift-cherrypick-robot @jwendell @openshift-ci-robot