Added a note to installation modules. #21554
Conversation
|
The preview will be available shortly at: |
There was a problem hiding this comment.
Suggest same change in the Helm module too.
There was a problem hiding this comment.
I think the placement is good. The other option is to add it to the end of the section. But I think the current option tells users that this section has CLI instructions, but if he wants to use the console he can access it before reading all of the CLI instructions.
There was a problem hiding this comment.
Suggest: The following...different platforms using the CLI.
modules/helm-installing-helm.adoc
Outdated
There was a problem hiding this comment.
Suggest adding an intro line here similar to that in odo: The following section describes how to install Helm on different platforms using the CLI.
Suggest adding the note before the prerequisite section, immediately after the above intro line.
|
/lgtm |
bergerhoffer
added
branch/enterprise-4.4
peer-review-needed
There was a problem hiding this comment.
It's up to you, but to me, it feels like this warning about not being able to use odo in a restricted env belongs in the NOTE. And then the additional info about finding the binaries in the web console belongs in normal text below the NOTE.
There was a problem hiding this comment.
- Suggest simplifying to something like "You can also download the latest binaries from the {product-title} web console." Or even combining into "You can also download the latest binaries from the {product-title} web console by clicking the ? icon in the upper-right corner and select Command Line Tools."
- Use a comma instead of a semicolon in the second sentence.
There was a problem hiding this comment.
You can't really download them this way. Clicking the ? icon in the upper-right corner and selecting Command Line Tools will lead user to the page with titles and URLs of different CLI tools' folders on the file server (odo, helm etc). And there, on the file server, they can download the actual binary file.
Otherwise, good call, thank you! I've shortened the sentence and included it as a part of introduction in both modules.
|
New changes are detected. LGTM label has been removed. |
|
@bergerhoffer I completely forgot about this PR! Could you merge please if everything's okay? |
bergerhoffer
added
branch/enterprise-4.5
peer-review-done
|
Sure thing @boczkowska, merging! Just FYI this will go into both 4.5 and 4.4 now. |
|
/cherrypick enterprise-4.5 |
|
/cherrypick enterprise-4.4 |
|
@bergerhoffer: new pull request created: #21858 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bergerhoffer: new pull request created: #21859 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Branch 4.4