Skip to content

Conversation

neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented May 21, 2020

Create an introduction to kiali components and observability.
https://issues.redhat.com/browse/OSSMDOC-23
https://issues.redhat.com/browse/OSSMDOC-22

This should be cherry picked from 4.2-4.5.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2020
@neal-timpe neal-timpe changed the title [wip] Kiali introduction [WIP] Kiali introduction May 21, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

Copy link

@cfcosta cfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good tô me.

@neal-timpe
Copy link
Contributor Author

@gbaufake Can you take a look at this also, or suggest someone on the Kiali QE team who might be able to help?

@gbaufake
Copy link

@neal-timpe can you assign as a reviewer?

@neal-timpe neal-timpe requested a review from gbaufake May 29, 2020 21:02
@neal-timpe neal-timpe requested a review from lucasponce June 2, 2020 14:50
@neal-timpe neal-timpe changed the title [WIP] Kiali introduction Kiali introduction Jun 2, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2020
@lucasponce
Copy link

As this is just an introduction, I guess just pointing user to the main features would be nice.

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the updates you've made. Just had a few more thoughts as I read through this revision.

@JStickler JStickler merged commit 3b92240 into openshift:master Jun 5, 2020
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.2

@openshift-cherrypick-robot

@JStickler: new pull request created: #22713

In response to this:

/cherry-pick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.3

@openshift-cherrypick-robot

@JStickler: new pull request created: #22714

In response to this:

/cherry-pick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot

@JStickler: new pull request created: #22715

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot

@JStickler: new pull request created: #22716

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-redhat
Copy link
Contributor

Hey @neal-timpe 16 commits? Also, missing labels.

@vikram-redhat
Copy link
Contributor

@JStickler ^

@neal-timpe
Copy link
Contributor Author

@vikram-redhat Sorry, I forgot to squash.

@neal-timpe neal-timpe deleted the kialiintro branch June 11, 2020 15:30
@vikram-redhat
Copy link
Contributor

@neal-timpe do you also need to bring in the images from the other location? I see some of the images are broken in the preview.

@neal-timpe
Copy link
Contributor Author

neal-timpe commented Jun 15, 2020

@vikram-redhat No, I think the right move is to remove those images. They're old, and I don't think they add much. I included them in the draft, didn't see them broken in the preview, and forgot about them.

I'm fixing this in a subsequent PR.

@vikram-redhat
Copy link
Contributor

@vikram-redhat No, I think the right move is to remove those images. They're old, and I don't think they add much. I included them in the draft, didn't see them broken in the preview, and forgot about them.

I'm fixing this in a subsequent PR.

Ah gotcha. So, the image shouldn't be there, and you are removing it from being referenced in the content in the next PR? I ask because we are getting warnings when building for the missing images (because they are currently being referenced).

@neal-timpe
Copy link
Contributor Author

Yes, I've made this change in this PR. #22635, which should be merged Thursday. Does it need to happen sooner?

@vikram-redhat
Copy link
Contributor

No Thursday is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants