-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Kiali introduction #22368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kiali introduction #22368
Conversation
The preview will be available shortly at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good tô me.
@gbaufake Can you take a look at this also, or suggest someone on the Kiali QE team who might be able to help? |
@neal-timpe can you assign as a reviewer? |
As this is just an introduction, I guess just pointing user to the main features would be nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the updates you've made. Just had a few more thoughts as I read through this revision.
/cherry-pick enterprise-4.2 |
@JStickler: new pull request created: #22713 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.3 |
@JStickler: new pull request created: #22714 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.4 |
@JStickler: new pull request created: #22715 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.5 |
@JStickler: new pull request created: #22716 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @neal-timpe 16 commits? Also, missing labels. |
@vikram-redhat Sorry, I forgot to squash. |
@neal-timpe do you also need to bring in the images from the other location? I see some of the images are broken in the preview. |
@vikram-redhat No, I think the right move is to remove those images. They're old, and I don't think they add much. I included them in the draft, didn't see them broken in the preview, and forgot about them. I'm fixing this in a subsequent PR. |
Ah gotcha. So, the image shouldn't be there, and you are removing it from being referenced in the content in the next PR? I ask because we are getting warnings when building for the missing images (because they are currently being referenced). |
Yes, I've made this change in this PR. #22635, which should be merged Thursday. Does it need to happen sooner? |
No Thursday is fine. |
Create an introduction to kiali components and observability.
https://issues.redhat.com/browse/OSSMDOC-23
https://issues.redhat.com/browse/OSSMDOC-22
This should be cherry picked from 4.2-4.5.