Skip to content

Conversation

Preeticp
Copy link
Contributor

@Preeticp Preeticp commented May 24, 2020

This PR adds content for Health checks via Developer perspective flow.
This is relevant to the 4.5 version of docs.
It has been reviewed by SMEs, QE, and peer reviewed by the Devtools docs team

@Preeticp Preeticp changed the title Health checks flow [WIP]Health checks flow May 24, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 24, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add and Edit Health checks content LGTM!.
Thanks @Preeticp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add probes be formatted as follows? Not sure if it's a UI item.

*Add Probes*

Copy link
Contributor Author

@Preeticp Preeticp May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the UI actually says Add name of the probe Probe which I mention in the example for Readiness probe. Have reworded it like this: Click the required health probe links to add them to the container.

@ahardin-rh ahardin-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label May 26, 2020
@ahardin-rh
Copy link
Contributor

Just some minor comments from me! Once the changes are squashed into one commit, we should be good to go! 😄

@Preeticp Preeticp changed the title [WIP]Health checks flow Health checks flow May 27, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2020
review edits

small fixes

review edits

structural edits and img

minor edits

review edits 2
@gajanan-more
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@Preeticp
Copy link
Contributor Author

@ahardin-rh I have fixed all the comments, and squashed the commits, please merge.

@kalexand-rh kalexand-rh merged commit 6039896 into openshift:master Jun 1, 2020
@bergerhoffer bergerhoffer mentioned this pull request Jun 25, 2020
@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.5

@openshift-cherrypick-robot

@bergerhoffer: new pull request created: #23294

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.