-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Health checks flow #22393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Health checks flow #22393
Conversation
The preview will be available shortly at: |
modules/odc-importing-codebase-from-git-to-create-application.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add and Edit Health checks content LGTM!.
Thanks @Preeticp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add probes be formatted as follows? Not sure if it's a UI item.
*Add Probes*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the UI actually says Add name of the probe Probe which I mention in the example for Readiness probe. Have reworded it like this: Click the required health probe links to add them to the container.
modules/odc-importing-codebase-from-git-to-create-application.adoc
Outdated
Show resolved
Hide resolved
Just some minor comments from me! Once the changes are squashed into one commit, we should be good to go! 😄 |
review edits small fixes review edits structural edits and img minor edits review edits 2
/lgtm |
@ahardin-rh I have fixed all the comments, and squashed the commits, please merge. |
/cherrypick enterprise-4.5 |
@bergerhoffer: new pull request created: #23294 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds content for Health checks via Developer perspective flow.
This is relevant to the 4.5 version of docs.
It has been reviewed by SMEs, QE, and peer reviewed by the Devtools docs team