Skip to content

aligning code blocks with openshift standards #24659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2020
Merged

aligning code blocks with openshift standards #24659

merged 1 commit into from
Aug 10, 2020

Conversation

neal-timpe
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 10, 2020
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@neal-timpe neal-timpe requested a review from JStickler August 10, 2020 17:38
JStickler
JStickler suggested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught a couple of issues that need minor fixes.

JStickler
JStickler approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JStickler JStickler merged commit 9492e30 into openshift:master Aug 10, 2020
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 10, 2020
Merged
@openshift-cherrypick-robot
Copy link

@JStickler: new pull request created: #24682

In response to this:

/cherry-pick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot
Copy link

@JStickler: new pull request created: #24683

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 10, 2020
Merged
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot
Copy link

@JStickler: new pull request created: #24684

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 10, 2020
Merged
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 10, 2020
Merged
@openshift-cherrypick-robot
Copy link

@JStickler: new pull request created: #24685

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe deleted the ossmcodeblockclean branch August 12, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JStickler JStickler JStickler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neal-timpe @openshift-docs-preview-bot @JStickler @openshift-cherrypick-robot @openshift-ci-robot