Skip to content

Conversation

@Erin-Donnelly
Copy link
Contributor

…ntainer Storage' to reflect link updates and new version numbers

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 2, 2020
@vikram-redhat
Copy link
Contributor

@bobfuru PTAL

@bobfuru bobfuru added this to the Next Release milestone Sep 3, 2020
@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 3, 2020
Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Erin-Donnelly. This looks good overall, added a few suggestions and comments for your consideration. Let me know when you've made changes and are ready for another look. I have a note to review and merge upon OCS GA but would appreciate if you could check that day to confirm. 😁

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/VMWare/VMware/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/VMWare/VMware/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCP docs use "Google Cloud Platform (GCP)". Not sure if you want to update here for consistency, so pointing it out.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all these sections, I don't think it's necessary to say "Instructions on" so I would start with the gerund:

  • Preparing to deploy...
  • Deploying...
  • Deploying and managing...
  • Troubleshooting...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "Red Hat OpenShift Container Platform", you can use the variable {product-title}. However, I'm not sure that "OpenShift Container Platform Google Cloud Platform clusters" is the right description.

IIUC, you should be able to drop OCP and just say "...on existing Google Cloud Platform clusters."

Alternatively, you could match with your AWS wording and say "...deploying OpenShift Container Storage using Google Cloud Platform for local or cloud storage"

Either way, it would be good to have consistent usage throughout all the rows in this table.

@Erin-Donnelly
Copy link
Contributor Author

@bobfuru thank you Bob! I've updated the docs to reflect all of your suggestions :) GA is tomorrow (9/9)

I'm having an issue squashing the commits, but I will keep trying!

@bobfuru
Copy link
Contributor

bobfuru commented Sep 8, 2020

@bobfuru thank you Bob! I've updated the docs to reflect all of your suggestions :) GA is tomorrow (9/9)

I'm having an issue squashing the commits, but I will keep trying!

Thanks, @Erin-Donnelly! Changes LGTM. Left one additional comment.

If you're still stuck getting commits to squash, try:

To begin, from terminal:

  1. git checkout OCS4.5-doc-updates
  2. git rebase -i HEAD~2

Then when your editor opens:

  1. Go to the 2nd commit and change "pick" to "squash"
  2. Save and quit.

Then when the next window opens:

  1. Add # in front of the second commit message to remove it.
  2. Save and quit.

Finally, from terminal (still same branch):

  1. git push origin HEAD --force

Hope that helps and works. Ping me if you still run into issues. And please double-check with me on 9/9 so I can be sure it is good to merge. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to change the link text to also say "Google Cloud Platform"?

…ntainer Storage' to reflect link updates and new version numbers
@bobfuru
Copy link
Contributor

bobfuru commented Sep 15, 2020

LGTM

@bmcelvee
Copy link
Contributor

Merging for @bobfuru.

@bmcelvee bmcelvee merged commit 432f468 into openshift:enterprise-4.5 Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.5 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants