-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Updated OCS section of 'Persistent storage using Red Hat OpenShift Co… #25219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated OCS section of 'Persistent storage using Red Hat OpenShift Co… #25219
Conversation
|
@bobfuru PTAL |
bobfuru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Erin-Donnelly. This looks good overall, added a few suggestions and comments for your consideration. Let me know when you've made changes and are ready for another look. I have a note to review and merge upon OCS GA but would appreciate if you could check that day to confirm. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/VMWare/VMware/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/VMWare/VMware/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OCP docs use "Google Cloud Platform (GCP)". Not sure if you want to update here for consistency, so pointing it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all these sections, I don't think it's necessary to say "Instructions on" so I would start with the gerund:
- Preparing to deploy...
- Deploying...
- Deploying and managing...
- Troubleshooting...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "Red Hat OpenShift Container Platform", you can use the variable {product-title}. However, I'm not sure that "OpenShift Container Platform Google Cloud Platform clusters" is the right description.
IIUC, you should be able to drop OCP and just say "...on existing Google Cloud Platform clusters."
Alternatively, you could match with your AWS wording and say "...deploying OpenShift Container Storage using Google Cloud Platform for local or cloud storage"
Either way, it would be good to have consistent usage throughout all the rows in this table.
|
@bobfuru thank you Bob! I've updated the docs to reflect all of your suggestions :) GA is tomorrow (9/9) I'm having an issue squashing the commits, but I will keep trying! |
Thanks, @Erin-Donnelly! If you're still stuck getting commits to squash, try: To begin, from terminal:
Then when your editor opens:
Then when the next window opens:
Finally, from terminal (still same branch):
Hope that helps and works. Ping me if you still run into issues. And please double-check with me on 9/9 so I can be sure it is good to merge. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to change the link text to also say "Google Cloud Platform"?
…ntainer Storage' to reflect link updates and new version numbers
8b8fb33 to
42c51a1
Compare
|
LGTM |
|
Merging for @bobfuru. |
…ntainer Storage' to reflect link updates and new version numbers