Skip to content

BZ1876886 - Add EBS max vol note #25348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

BZ1876886 - Add EBS max vol note #25348

merged 1 commit into from
Sep 11, 2020

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Sep 8, 2020 •
edited
Loading

BZ1876886
Adds note to docs for cloud admins to choose either in-tree or CSI to report correct max vol number in AWS EBS.

@jsafrane and @qinpingli - PTAL and make sure wording and placement both make sense, thanks! Also, please confirm that this applies only to OCP 4.6+?

Also, related to https://bugzilla.redhat.com/show_bug.cgi?id=1794729.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2020
@bobfuru bobfuru added branch/enterprise-4.6 and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2020
@bobfuru bobfuru added this to the Future Release milestone Sep 8, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2020
qinpingli
qinpingli reviewed Sep 9, 2020
View reviewed changes
qinpingli
qinpingli reviewed Sep 9, 2020
View reviewed changes
qinpingli
qinpingli reviewed Sep 9, 2020
View reviewed changes
@qinpingli
Copy link

qinpingli commented Sep 9, 2020

BZ1876886
Adds note to docs for cloud admins to choose either in-tree or CSI to report correct max vol number in AWS EBS.

@jsafrane and @qinpingli - PTAL and make sure wording and placement both make sense, thanks! Also, please confirm that this applies only to OCP 4.6+?

From OCP4.5 we support AWS EBS CSI driver, so 4.5 has the same issue.

@bobfuru bobfuru modified the milestones: Future Release, Next Release Sep 9, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Sep 9, 2020

@jsafrane and @qinpingli Thanks for the feedback. Can you both PTAL at updates and let me know if this is LGTM?

@qinpingli
Copy link

qinpingli commented Sep 10, 2020

@bobfuru Thanks for the update, lgtm.

@jsafrane
Copy link
Contributor

jsafrane commented Sep 10, 2020

lgtm

@bobfuru bobfuru added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 10, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Sep 10, 2020

@openshift/team-documentation PTAL

lbarbeevargas
lbarbeevargas reviewed Sep 11, 2020
View reviewed changes
Copy link
Contributor

@lbarbeevargas lbarbeevargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobfuru Looks good! Just a comment for clarification and possible update to the module title case.

@bobfuru bobfuru added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 11, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Sep 11, 2020

The preview will be available shortly at:

@bobfuru
Copy link
Contributor Author

bobfuru commented Sep 11, 2020

New questions raised about whether to include KUBE_MAX_PD_VOLS info in for in-tree support in 4.x. Details in Slack thread: https://coreos.slack.com/archives/GK0DA0JR5/p1599824917323100

@bobfuru
Copy link
Contributor Author

bobfuru commented Sep 11, 2020

New questions raised about whether to include KUBE_MAX_PD_VOLS info in for in-tree support in 4.x. Details in Slack thread: https://coreos.slack.com/archives/GK0DA0JR5/p1599824917323100

Decision was that it can't be configured at all in 4.x and this related bug was closed: https://bugzilla.redhat.com/show_bug.cgi?id=1877311

Merging...

@bobfuru bobfuru merged commit ed66c01 into openshift:master Sep 11, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Sep 11, 2020

/cherrypick enterprise-4.5

@bobfuru
Copy link
Contributor Author

bobfuru commented Sep 11, 2020

/cherrypick enterprise-4.6

@bobfuru bobfuru deleted the BZ1876886 branch September 11, 2020 16:46
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 11, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 11, 2020

@bobfuru: new pull request created: #25408

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 11, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 11, 2020

@bobfuru: new pull request created: #25409

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 11, 2020
Merged
Merged
@bobfuru bobfuru mentioned this pull request Sep 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@jsafrane jsafrane jsafrane left review comments

@qinpingli qinpingli qinpingli left review comments

@lbarbeevargas lbarbeevargas lbarbeevargas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.5 branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@bobfuru @qinpingli @jsafrane @openshift-docs-preview-bot @openshift-cherrypick-robot @lbarbeevargas @openshift-ci-robot