[enterprise-4.6] modules/dynamic-provisioning-available-plugins: Drop xref #26274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrefs aren't allowed in modules: $ grep -A1 'You must not include xrefs' modules/mod-docs-ocp-conventions.adoc You must not include xrefs in modules or create an xref to a module. You can only use xrefs to link from one assembly to another. And we can't move this module out into an assembly directory, because it is consumed from two places: $ git --no-pager grep dynamic-provisioning-available-plugins post_installation_configuration/storage-configuration.adoc:include::modules/dynamic-provisioning-available-plugins.adoc[leveloffset=+3] storage/dynamic-provisioning.adoc:include::modules/dynamic-provisioning-available-plugins.adoc[leveloffset=+1] We could: a. Trim down post_installation_configuration to just xref the storage assembly, instead of duping so much of it's content via modules. b. Drop the module and instead inline (some of) it with copy/paste in both assemblies. c. Remove the xref. With this commit, I'm going with (c), removing the xref which was added in 57961f1 ([STOR] Include section on the OpenStack Manila CSI Driver, 2020-05-12, openshift#22199).
openshift-ci-robot
added
the
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #26255
/assign bobfuru