Skip to content

Conversation

@jboxman
Copy link
Contributor

@jboxman jboxman commented Oct 26, 2020

@alexanderConstantinescu, the update will live here once identified.

@vikram-redhat, this update will need to go in to clarify platform support for this feature in 4.6.

Preview:

@jboxman jboxman added this to the Future Release milestone Oct 26, 2020
@jboxman jboxman self-assigned this Oct 26, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 26, 2020
@jboxman jboxman changed the title Clarify OVN-Kubernetes egress IP address platform support BZ#1891515 - Clarify OVN-Kubernetes egress IP address platform support Oct 26, 2020
@alexanderConstantinescu

/cc @alexanderConstantinescu

@openshift-docs-preview-bot

The preview will be available shortly at:

@jboxman
Copy link
Contributor Author

jboxman commented Nov 6, 2020

@alexanderConstantinescu, I've updated the language; maybe this is more suitable.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase to or any other public cloud platform incompatible with the automatic layer 2 network manipulation required by OpenShift's egress IP feature.. The reason is that in the future this will work, it's just that we currently have not done the necessary development for that to happen.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase here too, to the following: do not support automatic assignment of an egress IP address following OpenShift's current assignment procedure.. For the same reason I mentioned above.

@jboxman jboxman added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 12, 2020
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it matters, but you use different examples here than in the NOTE above the table. Also, is it necessary to have that same warning both places?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However looking again, you already have "No" in the column for whether it's supported, so why would this note be necessary saying that these cloud platforms don't support the feature? The NOTE above made it sound like SOME public clouds might be supported if they have the "automatic layer 2 network manipulation required by the egress IP feature."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bergerhoffer, so while this feature might work with manual intervention for IP address assignment on some cloud providers, officially it was never tested by QE, so we don't actually support it on any cloud platform. And even if it did otherwise work, without automatic address assignment, it's incomplete.

There's probably no reason to include the footnote as well, though. Mostly it just looks awesome.

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 12, 2020
@jboxman jboxman merged commit 6e53c70 into openshift:master Nov 16, 2020
@jboxman jboxman deleted the bz-1891515 branch November 16, 2020 21:24
@jboxman
Copy link
Contributor Author

jboxman commented Nov 16, 2020

/cherry-pick enterprise-4.7

@jboxman
Copy link
Contributor Author

jboxman commented Nov 16, 2020

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 16, 2020

@jboxman: new pull request created: #27418

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 16, 2020

@jboxman: new pull request created: #27419

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants