-
Notifications
You must be signed in to change notification settings - Fork 1.8k
BZ#1891515 - Clarify OVN-Kubernetes egress IP address platform support #26718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
|
@alexanderConstantinescu, I've updated the language; maybe this is more suitable. |
modules/nw-egress-ips-about.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rephrase to or any other public cloud platform incompatible with the automatic layer 2 network manipulation required by OpenShift's egress IP feature.. The reason is that in the future this will work, it's just that we currently have not done the necessary development for that to happen.
modules/nw-egress-ips-about.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rephrase here too, to the following: do not support automatic assignment of an egress IP address following OpenShift's current assignment procedure.. For the same reason I mentioned above.
bergerhoffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some thoughts
modules/nw-egress-ips-about.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it matters, but you use different examples here than in the NOTE above the table. Also, is it necessary to have that same warning both places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However looking again, you already have "No" in the column for whether it's supported, so why would this note be necessary saying that these cloud platforms don't support the feature? The NOTE above made it sound like SOME public clouds might be supported if they have the "automatic layer 2 network manipulation required by the egress IP feature."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bergerhoffer, so while this feature might work with manual intervention for IP address assignment on some cloud providers, officially it was never tested by QE, so we don't actually support it on any cloud platform. And even if it did otherwise work, without automatic address assignment, it's incomplete.
There's probably no reason to include the footnote as well, though. Mostly it just looks awesome.
|
/cherry-pick enterprise-4.7 |
|
/cherry-pick enterprise-4.6 |
|
@jboxman: new pull request created: #27418 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jboxman: new pull request created: #27419 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@alexanderConstantinescu, the update will live here once identified.
@vikram-redhat, this update will need to go in to clarify platform support for this feature in 4.6.
Preview: