Skip to content

BZ1846458 - Remove note that ES scaling is not supported #27773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

BZ1846458 - Remove note that ES scaling is not supported #27773

merged 1 commit into from
Dec 9, 2020

Conversation

bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Dec 1, 2020 •
edited
Loading

BZ1846458
As of OCP 4.5, the note about scaling ES nodes being unsupported is no longer relevant. There is now a section added in docs on scaling down ES one node/pod at a time: https://github.com/openshift/openshift-docs/pull/27404/files#diff-133e6e62a5aac180545525ba042091c8662a66b3a160b188dfead122e1445ff9

PREVIEW LINK:
https://bz1846458--ocpdocs.netlify.app/openshift-enterprise/latest/logging/config/cluster-logging-log-store.html

@bobfuru bobfuru added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 labels Dec 1, 2020
@bobfuru bobfuru added this to the Next Release milestone Dec 1, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 1, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Dec 1, 2020

@ewolinetz Could you PTAL and let me know if it makes sense to remove this note about non-support for scaling ES nodes? I know you recently discussed this matter with @mburke5678. Thanks!

@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@bobfuru
Copy link
Contributor Author

bobfuru commented Dec 9, 2020 •
edited
Loading

@duanwei33 or@ewolinetz PTAL to confirm it is OK to remove this note:


> [NOTE]
> ====
> Scaling down Elasticsearch nodes is not supported. When scaling down, Elasticsearch pods can be accidentally deleted,  
> possibly resulting in shards not being allocated and replica shards being lost.
> ====

kalexand-rh
kalexand-rh reviewed Dec 9, 2020
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If QE agrees, it LGTM.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 9, 2020
@ewolinetz
Copy link

lgtm

@bobfuru bobfuru merged commit 04c792e into openshift:master Dec 9, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Dec 9, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.5

@bobfuru
Copy link
Contributor Author

bobfuru commented Dec 9, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@bobfuru
Copy link
Contributor Author

bobfuru commented Dec 9, 2020 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@bobfuru bobfuru deleted the BZ1846458 branch December 9, 2020 23:24
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 9, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 9, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #28017

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 9, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 9, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #28018

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 9, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 9, 2020 •
edited by openshift-ci-robot
Loading

@bobfuru: new pull request created: #28019

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@bobfuru @openshift-docs-preview-bot @ewolinetz @openshift-cherrypick-robot @kalexand-rh @openshift-ci-robot