-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[RHDEVDOCS-2333] - Update ability to filter helm charts when multiple Helm repos are available #28377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The preview will be available shortly at:
|
/lgtm The Textual changes look good. Please check the rendered version to ensure that the image is rendered properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions. Please squash your commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a cluster administrator, you can add custom Helm chart repositories to your cluster, and enable access to the Helm charts from these repositories in the *Developer Catalog*. | |
As a cluster administrator, you can add custom Helm chart repositories to your cluster and enable access to the Helm charts from these repositories in the *Developer Catalog*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need the screenshot.
Use the *Chart repositories* filter to search for the required Helm Chart | |
For example, use the *Chart repositories* filter to search for a Helm chart from the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a cluster administrator removes all of the chart repositories then the user cannot view the Helm option in the *+Add* view, *Developer Catalog*, and left navigation panel. | |
If a cluster administrator removes all of the chart repositories, then you cannot view the Helm option in the *+Add* view, *Developer Catalog*, and left navigation panel. |
The procedure to add a Helm repository is probably not the right place to surface what happens when you remove them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great suggestion. Will change it accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. Navigate to the *Developer Catalog* in the web console to verify that the helm charts from the Azure chart repository are displayed. | |
. Navigate to the *Developer Catalog* in the web console to verify that the Helm charts from the chart repository are displayed. |
It looks like Helm is always capitalized, the vast majority of the time chart is not capitalized, and since Azure is part of the example, I don't think it makes sense to call it out specifically in this step.
I think it would be helpful to point out that the name of the chart repository is shown in the Chart Repository list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems right, we can incorporate this change.
New changes are detected. LGTM label has been removed. |
@kalexand-rh Squashed commits on this PR. Kindly check and merge the PR. |
/cherrypick enterprise-4.7 |
@kalexand-rh: new pull request created: #28463 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updated the information for Chart Repositories filter with its screenshot and a few minor changes.
JIRA issue: [RHDEVDOCS-2333] | URL: https://issues.redhat.com/browse/RHDEVDOCS-2333
Version: OpenShift 4.7
Previous PR: #28054