Skip to content

Conversation

rishumehra
Copy link
Contributor

Updated the information for Chart Repositories filter with its screenshot and a few minor changes.

JIRA issue: [RHDEVDOCS-2333] | URL: https://issues.redhat.com/browse/RHDEVDOCS-2333

Version: OpenShift 4.7

Previous PR: #28054

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 6, 2021
@openshift-docs-preview-bot

The preview will be available shortly at:

@Preeticp
Copy link
Contributor

Preeticp commented Jan 6, 2021

/lgtm

The Textual changes look good. Please check the rendered version to ensure that the image is rendered properly.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 6, 2021
Copy link

@gajanan-more gajanan-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions. Please squash your commits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As a cluster administrator, you can add custom Helm chart repositories to your cluster, and enable access to the Helm charts from these repositories in the *Developer Catalog*.
As a cluster administrator, you can add custom Helm chart repositories to your cluster and enable access to the Helm charts from these repositories in the *Developer Catalog*.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the screenshot.

Suggested change
Use the *Chart repositories* filter to search for the required Helm Chart
For example, use the *Chart repositories* filter to search for a Helm chart from the repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If a cluster administrator removes all of the chart repositories then the user cannot view the Helm option in the *+Add* view, *Developer Catalog*, and left navigation panel.
If a cluster administrator removes all of the chart repositories, then you cannot view the Helm option in the *+Add* view, *Developer Catalog*, and left navigation panel.

The procedure to add a Helm repository is probably not the right place to surface what happens when you remove them all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great suggestion. Will change it accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Navigate to the *Developer Catalog* in the web console to verify that the helm charts from the Azure chart repository are displayed.
. Navigate to the *Developer Catalog* in the web console to verify that the Helm charts from the chart repository are displayed.

It looks like Helm is always capitalized, the vast majority of the time chart is not capitalized, and since Azure is part of the example, I don't think it makes sense to call it out specifically in this step.

I think it would be helpful to point out that the name of the chart repository is shown in the Chart Repository list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right, we can incorporate this change.

@kalexand-rh kalexand-rh added branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR labels Jan 7, 2021
@kalexand-rh kalexand-rh added this to the Future Release milestone Jan 7, 2021
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2021
@rishumehra
Copy link
Contributor Author

@kalexand-rh Squashed commits on this PR. Kindly check and merge the PR.

@kalexand-rh kalexand-rh merged commit 2ed1f34 into openshift:master Jan 8, 2021
@kalexand-rh
Copy link
Contributor

kalexand-rh commented Jan 8, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 8, 2021

@kalexand-rh: new pull request created: #28463

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants