Add Helm module. #28544
Add Helm module. #28544
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
The preview will be available shortly at:
|
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
There was a problem hiding this comment.
You need to make the ID match the module name: https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc#module-file-metadata
modules/helm-disabling-helm-chart-repository-in-the-cluster.adoc
Outdated
Show resolved
Hide resolved
modules/helm-disabling-helm-chart-repository-in-the-cluster.adoc
Outdated
Show resolved
Hide resolved
modules/helm-disabling-helm-chart-repository-in-the-cluster.adoc
Outdated
Show resolved
Hide resolved
modules/helm-disabling-helm-chart-repository-in-the-cluster.adoc
Outdated
Show resolved
Hide resolved
modules/helm-disabling-helm-chart-repository-in-the-cluster.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Assemblies are supposed to meet discrete use goals, and removing the repo is the opposite of what the user would come to this assembly to do. I strongly suggest making a separate assembly to contain the module instead of adding it to this assembly.
There was a problem hiding this comment.
@kalexand-rh thank you for your feedback! I've committed all your suggestions and added a new assembly with a small introduction that now contains the modules. Please take a look when you have time. Thank you.
modules/helm-disabling-helm-chart-repository-in-the-cluster.adoc
Outdated
Show resolved
Hide resolved
kalexand-rh
added
branch/enterprise-4.7
peer-review-done
|
/cherrypick enterprise-4.7 |
|
@kalexand-rh: new pull request created: #29001 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
No description provided.