Skip to content

Bug 1921281: remove --export flag from oc #28943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2021
Merged

Bug 1921281: remove --export flag from oc #28943

merged 1 commit into from
Feb 1, 2021

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Jan 28, 2021 •
edited
Loading

@bergerhoffer bergerhoffer added peer-review-needed Signifies that the peer review team needs to review this PR branch/enterprise-4.6 branch/enterprise-4.7 labels Jan 28, 2021
@bergerhoffer bergerhoffer added this to the Next Release milestone Jan 28, 2021
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 28, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2021

@bergerhoffer: This pull request references Bugzilla bug 1921281, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1921281: remove --export flag from oc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 28, 2021
This was referenced Jan 28, 2021
Closed
Merged
Merged
@netlify
Copy link

netlify bot commented Jan 28, 2021

Deploy preview for osdocs ready!

Built with commit 9c9754e

https://deploy-preview-28943--osdocs.netlify.app

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Jan 28, 2021

@soltysh @zhouying7780 Can you please review?

Preview: https://deploy-preview-28943--osdocs.netlify.app/openshift-enterprise/latest/openshift_images/using-templates.html#templates-create-from-existing-object_using-templates

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 28, 2021
jeana-redhat
jeana-redhat approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jboxman
Copy link
Contributor

jboxman commented Jan 29, 2021

@bergerhoffer is this also related to this #28623?

@zhouying7780
Copy link

zhouying7780 commented Jan 29, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2021
soltysh
soltysh approved these changes Feb 1, 2021
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bergerhoffer bergerhoffer merged commit 97186f6 into openshift:master Feb 1, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2021

@bergerhoffer: All pull requests linked via external trackers have merged:

Bugzilla bug 1921281 has been moved to the MODIFIED state.

In response to this:

Bug 1921281: remove --export flag from oc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

/cherrypick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 1, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

@bergerhoffer: new pull request created: #29008

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 1, 2021 •
edited by openshift-ci-robot
Loading

@bergerhoffer: new pull request created: #29009

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 1, 2021
Merged
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Feb 1, 2021

@bergerhoffer is this also related to this #28623?

Yes it is, thanks @jboxman! I'll close that issue.

@bergerhoffer bergerhoffer mentioned this pull request Feb 1, 2021
Closed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2021

@bergerhoffer: Bugzilla bug 1921281 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Bug 1921281: remove --export flag from oc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer bergerhoffer deleted the pr-28907 branch August 3, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat approved these changes

+1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@zhouying7780 zhouying7780

Labels

branch/enterprise-4.6 branch/enterprise-4.7 bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@bergerhoffer @openshift-ci-robot @jboxman @zhouying7780 @openshift-cherrypick-robot @soltysh @jeana-redhat