Skip to content

MIG528: DVM and missing node selectors to Troubleshooting (1.4.1) #29219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2021
Merged

MIG528: DVM and missing node selectors to Troubleshooting (1.4.1) #29219

merged 1 commit into from
Feb 9, 2021

Conversation

apinnick
Copy link
Contributor

@apinnick apinnick commented Feb 7, 2021 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2021
@apinnick apinnick added branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2021
@netlify
Copy link

netlify bot commented Feb 7, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit cbcf49c

https://deploy-preview-29219--osdocs.netlify.app

@apinnick apinnick added this to the Next Release milestone Feb 7, 2021
sergiordlr
sergiordlr approved these changes Feb 8, 2021
View reviewed changes
Copy link

@sergiordlr sergiordlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thank you very much!

@apinnick apinnick marked this pull request as ready for review February 8, 2021 12:14
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2021
@apinnick apinnick added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 8, 2021
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 8, 2021
adellape
adellape reviewed Feb 8, 2021
View reviewed changes
Copy link
Contributor

@adellape adellape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor questions! 👍

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 8, 2021
hu-weihua
hu-weihua reviewed Feb 8, 2021
View reviewed changes
hu-weihua
hu-weihua reviewed Feb 8, 2021
View reviewed changes
@apinnick apinnick force-pushed the mig528-dvm-node-selectors-issue branch from 4c3f8cb to cfae14f Compare February 9, 2021 09:49
@apinnick apinnick added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Feb 9, 2021
@apinnick apinnick force-pushed the mig528-dvm-node-selectors-issue branch from cfae14f to cbcf49c Compare February 9, 2021 11:13
@apinnick apinnick merged commit c21e3ff into openshift:master Feb 9, 2021
@apinnick apinnick deleted the mig528-dvm-node-selectors-issue branch February 9, 2021 11:15
@apinnick
Copy link
Contributor Author

apinnick commented Feb 9, 2021

/cherrypick enterprise-4.5

@apinnick
Copy link
Contributor Author

apinnick commented Feb 9, 2021

/cherrypick enterprise-4.6

@apinnick
Copy link
Contributor Author

apinnick commented Feb 9, 2021

/cherrypick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2021
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #29294

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2021
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #29295

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 9, 2021
Merged
@openshift-cherrypick-robot
Copy link

@apinnick: new pull request created: #29296

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@adellape adellape adellape left review comments

@hu-weihua hu-weihua hu-weihua left review comments

@sergiordlr sergiordlr sergiordlr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

6 participants

@apinnick @openshift-cherrypick-robot @adellape @hu-weihua @sergiordlr @openshift-ci-robot