Skip to content

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Mar 2, 2021

… value are wrong
merge to master only, not to the enterprise branches for now.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 2, 2021
@netlify
Copy link

netlify bot commented Mar 2, 2021

Deploy preview for osdocs ready!

Built with commit 82eec3e

https://deploy-preview-29998--osdocs.netlify.app

@rolfedh rolfedh changed the title RHDEVDOCS-2603 In secure forward the self_hostname the definition and… RHDEVDOCS-2602 In secure forward the self_hostname the definition and… Mar 2, 2021
@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 2, 2021

@r2d2rnd Oscar, please mark this as lgtm.

@r2d2rnd
Copy link

r2d2rnd commented Mar 2, 2021

@rolfedh LGTM.

Thank you so much

@bmcelvee
Copy link
Contributor

bmcelvee commented Mar 2, 2021

The change LGTM!

It looks like the module is in the unused topics folder, and I couldn't find it in the preview build. Is it moving out of that folder? Thanks!

@bmcelvee bmcelvee added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 2, 2021
@bmcelvee bmcelvee added this to the Next Release milestone Mar 2, 2021
@bmcelvee
Copy link
Contributor

bmcelvee commented Mar 2, 2021

Merging to master only.

@bmcelvee bmcelvee merged commit ea96294 into openshift:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants