-
Notifications
You must be signed in to change notification settings - Fork 1.8k
CNV-10445 [1926199] VM Migration of mixed CPU (AMD,Intel) #30340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for osdocs ready! Built with commit 0990a18 |
/lgtm |
@ILpinto: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should change the sentence to :
To be able to migrate virtual machines into the cluster, ensure that all nodes in a single pool use the same type of CPU. For example, nodes in one pool can use AMD processors and nodes in another pool can use Intel processors, and so on. Avoid mixing different CPU types in the same pool.
Thanks for the suggestion. I'll see what the peer reviewers prefer in terms using "into the" vs. "to a" --- our style guidelines are pretty specific in cases like this. |
5d73438
to
5d7fca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested a rewrite for clarity. Please let me know if you have any questions. Thanks!
Which versions does this apply to?
2dc1f74
to
3a8516d
Compare
4496d8f
to
3beff99
Compare
05bcf5d
to
1273f0d
Compare
cbf98bd
to
a034d34
Compare
@bgaydosrh, I think we are ok to move on , aren't we? |
yes, I dropped my "hold". If the text is good, you can /lgtm it, but I would like to see the "CPU pool" term dropped from this PR title. |
Moving this to Peer Review for final check and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise LGTM
/cherrypick enterprise-4.8 |
/cherrypick enterprise-4.7 |
@sjhala-ccs: new pull request created: #31624 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sjhala-ccs: new pull request created: #31625 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.6 |
@sjhala-ccs: new pull request created: #31626 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.5 |
@sjhala-ccs: new pull request created: #31627 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Label for enterprise-4.5, 4.6, 4.7, 4.8
Added this bullet to the prereqs listed in the Configuring your cluster for OpenShift Virtualization assembly:
Before you migrate virtual machines to a cluster, ensure that all nodes in a single pool use the same type of CPU. For example, place nodes that use AMD processors in one pool and place nodes that use Intel processors in a different pool. Do not mix different CPU types in the same pool.
Jira: https://issues.redhat.com/browse/CNV-10445
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1926199
Test Build: https://deploy-preview-30340--osdocs.netlify.app/openshift-enterprise/latest/virt/install/preparing-cluster-for-virt.html
Tagging @kobi86 for Code Review
Tagging Israel Pinto for QE Review in Jira record.