-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS-2900 Tracker for #30976 Issue in file logging/cluster-loggi… #31302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for osdocs ready! Built with commit bdfa0d5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (since I work on the Jaeger and Service Mesh content).
Also, it looks like this PR also addresses #30981.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - noted a few small things that you may or may not consider in scope for this (not the change you were looking at, but in the same sentences). LMK if you want to do anything about them or if you'd like me to go ahead and merge and CP to 4.7+
…ng-deploying.adoc Add "OpenShift" to "Elasticsearch Operator"
/cherrypick enterprise-4.8 |
/cherrypick enterprise-4.7 |
@jeana-redhat: #31302 failed to apply on top of branch "enterprise-4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jeana-redhat: #31302 failed to apply on top of branch "enterprise-4.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual CP of PR #31302 to 4.7 yet again
…ng-deploying.adoc Add "OpenShift" to "Elasticsearch Operator"