OSDOCS-2095: Added release note for descheduler metrics #31583
Conversation
bergerhoffer
added
peer-review-needed
openshift-ci-robot
added
the
size/XS
|
Deploy preview for osdocs ready! Built with commit e762125 |
|
@bergerhoffer LGTM |
jboxman
added
peer-review-done
|
@ingvagabund @kasturinarra Can you please review this release notes update? Thanks! |
There was a problem hiding this comment.
@bergerhoffer not sure if the description for this is apt, as below is the info we see on prometheus for the descheduler_build_info, which does not contain anything about descheduler build information.
descheduler_build_info{GoVersion="go1.16.1", endpoint="https", instance="10.129.3.143:10258", job="metrics", namespace="openshift-kube-descheduler-operator", pod="cluster-6c89d56fdd-5qzrq", service="metrics"}
There was a problem hiding this comment.
It depends on how the descheduler operand was actually built. Checking https://github.com/openshift/descheduler/blob/master/images/descheduler/Dockerfile.rhel7#L4 we don't set the right LDFLAGS. Lemme fix that. Though, the description is still valid.
bergerhoffer
force-pushed
the
OSDOCS-2095
branch
from
fa38d33 to
9f40e26
Compare
bergerhoffer
force-pushed
the
OSDOCS-2095
branch
from
9f40e26 to
e762125
Compare
|
@bergerhoffer: base branch (enterprise-4.8) needs to differ from target branch (enterprise-4.8) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
https://issues.redhat.com/browse/OSDOCS-2095
Preview: https://deploy-preview-31583--osdocs.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-8-release-notes.html#ocp-4-8-nodes-descheduler-metrics