-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSSMDOC-311 values for CPU and memory switched. #31707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for osdocs ready! Built with commit 8379ece |
modules/jaeger-config-storage.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JStickler Default values should be as follows,
CPU: 1
Memory: 16Gi
NodeCount: 3
References:
- https://github.com/maistra/istio-operator/blob/53ae3883c096ca70278f918e0a118eb69a0603f8/resources/helm/v2.0/istio-telemetry/tracing/templates/jaeger-production-elasticsearch.yaml#L68~L69
- https://github.com/maistra/istio-operator/blob/53ae3883c096ca70278f918e0a118eb69a0603f8/resources/helm/v2.0/istio-telemetry/tracing/templates/jaeger-production-elasticsearch.yaml#L48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @JStickler, LGTM
/cherry-pick enterprise-4.6 |
@neal-timpe: new pull request created: #31897 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.7 |
@neal-timpe: new pull request created: #31898 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.8 |
@neal-timpe: new pull request created: #31899 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.5 |
@neal-timpe: new pull request created: #31900 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The elasticsearch cpu and memory values present in the table somehow got swapped.
The example YAML is correct, but this needed to be fixed in parameter table 7.
QE review - approved by Jkandasa
Peer review - Approved by neal-timpe