-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WIP] odo NodeJS in a disconnected env. #31914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for osdocs ready! Built with commit 2f42fed |
...oper-cli-odo-creating-a-nodejs-application-by-using-a-devfile-in-a-disconnected-cluster.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be odo create <cmp-name> --starter
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though users provide their own similar devfile (which has starter project) they need to pass component name, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prietyc123 thank you! I've updated the commands and also added the warnings about the external dependencies (hopefully, the support will allow these). PTAL and let me know if you're okay with the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boczkowska Thanks for the changes 🙂
LGTM
...oper-cli-odo-creating-a-nodejs-application-by-using-a-devfile-in-a-disconnected-cluster.adoc
Outdated
Show resolved
Hide resolved
...eloper-cli-odo-creating-a-java-application-by-using-a-devfile-in-a-disconnected-cluster.adoc
Outdated
Show resolved
Hide resolved
...eloper-cli-odo-creating-a-java-application-by-using-a-devfile-in-a-disconnected-cluster.adoc
Outdated
Show resolved
Hide resolved
...eloper-cli-odo-creating-a-java-application-by-using-a-devfile-in-a-disconnected-cluster.adoc
Outdated
Show resolved
Hide resolved
...oper-cli-odo-creating-a-nodejs-application-by-using-a-devfile-in-a-disconnected-cluster.adoc
Outdated
Show resolved
Hide resolved
...oper-cli-odo-creating-a-nodejs-application-by-using-a-devfile-in-a-disconnected-cluster.adoc
Outdated
Show resolved
Hide resolved
/cherry-pick enterprise-4.7 |
@JStickler: new pull request created: #32178 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick enterprise-4.8 |
@JStickler: new pull request created: #32179 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.