Skip to content

Conversation

yhontyk
Copy link
Contributor

@yhontyk yhontyk commented Apr 26, 2021

No description provided.

@yhontyk yhontyk changed the title odo NodeJS and Java in a disconnected env. [WIP] odo NodeJS and Java in a disconnected env. Apr 26, 2021
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 26, 2021
@netlify
Copy link

netlify bot commented Apr 26, 2021

Deploy preview for osdocs ready!

Built with commit 2f42fed

https://deploy-preview-31914--osdocs.netlify.app

@yhontyk yhontyk changed the title [WIP] odo NodeJS and Java in a disconnected env. [WIP] odo NodeJS in a disconnected env. Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be odo create <cmp-name> --starter, no?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though users provide their own similar devfile (which has starter project) they need to pass component name, I think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prietyc123 thank you! I've updated the commands and also added the warnings about the external dependencies (hopefully, the support will allow these). PTAL and let me know if you're okay with the changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boczkowska Thanks for the changes 🙂
LGTM

@JStickler JStickler merged commit fa82d3c into openshift:master May 4, 2021
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot

@JStickler: new pull request created: #32178

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot

@JStickler: new pull request created: #32179

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yhontyk yhontyk deleted the odoRestrictedCompontent branch May 4, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants