[srvls][RHDEVDOCS-2749] Add functions with eventing docs #32585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Deploy preview for osdocs ready! Built with commit 034c60e028f2c6d84321d5418a824ee438fee621 |
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: e078a9f 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60ae6b33c8f13f0007324c9b 😎 Browse the preview: https://deploy-preview-32585--osdocs.netlify.app |
abrennan89
force-pushed
the
eventsourcefunc
branch
from
32f8a79 to
7038703
Compare
openshift-ci
bot
added
size/L
abrennan89
force-pushed
the
eventsourcefunc
branch
from
dfb273b to
8f40e19
Compare
|
Thanks @abrennan89 looks good to me. Have added one comment, PTAL if it make sense |
abrennan89
force-pushed
the
eventsourcefunc
branch
from
af5b68a to
329da69
Compare
Preeticp
reviewed
May 20, 2021
There was a problem hiding this comment.
A minor nit, otherwise looks great to me. Thank you @abrennan89
openshift-ci
bot
added
the
needs-rebase
abrennan89
force-pushed
the
eventsourcefunc
branch
from
329da69 to
71071ed
Compare
openshift-ci
bot
removed
the
needs-rebase
abrennan89
force-pushed
the
eventsourcefunc
branch
2 times, most recently
from
3b98ea3 to
b66381b
Compare
abrennan89
force-pushed
the
eventsourcefunc
branch
3 times, most recently
from
99eef3c to
dd1e457
Compare
abrennan89
added
branch/enterprise-4.8
dev-tools
abrennan89
force-pushed
the
eventsourcefunc
branch
from
dd1e457 to
28134d6
Compare
|
QE Approved |
jeana-redhat
added
the
peer-review-done
abrennan89
force-pushed
the
eventsourcefunc
branch
from
28134d6 to
7f672ae
Compare
abrennan89
force-pushed
the
eventsourcefunc
branch
from
7f672ae to
e078a9f
Compare
abrennan89
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cherrypick enterprise-4.8 |
|
@abrennan89: new pull request created: #32862 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies for 4.8+
Should be rebased on top of #32453 when it is merged.